Angular: Configuration Components Deprecation Warning #31511
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a deprecation warning system for legacy nested configuration components in the DevExtreme Angular wrapper. The implementation detects when developers use generic legacy nested components (like dxi-item, dxo-animation) and warns them to upgrade to component-specific variants (like dxi-accordion-item, dxo-accordion-animation).
Key changes:
- New deprecation warning utility that detects legacy nested component usage and suggests modern replacements
- Integration of the warning system into the nested option lifecycle
- Comprehensive mapping of legacy to modern selectors across all DevExtreme components
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme-angular/src/core/nested-option.ts |
Added import and integration of the deprecation warning into NestedOptionHost.setNestedOption() |
packages/devextreme-angular/src/core/deprecated-config-warning.ts |
New file implementing the deprecation warning logic with class name parsing, host component detection, and console warning emission |
packages/devextreme-angular/src/core/deprecated-config-map.ts |
New generated file containing mappings from host components to their legacy/modern nested component selector pairs |
|
|
||
| const warnedUsages = new Set<string>(); | ||
|
|
||
| const LEGACY_CLASS_NAME_REGEXP = /^Dx([io])([A-Za-z0-9]+)Component$/; |
There was a problem hiding this comment.
As I understand this regexp matches any Dx[io]..Component, not only legacy?
Lets name it NESTED_CLASS_NAME_REGEXP?
| const [, type, rest] = match; | ||
| const prefix = type === 'o' ? 'dxo-' : 'dxi-'; | ||
|
|
||
| return `${prefix}${toKebabCase(rest)}`; |
There was a problem hiding this comment.
How about this:
if use regexp like /^(Dx[io][A-Z]\w+)Component$/;
then do return toKebabCase(match[1]);
No description provided.