Skip to content

Commit 8e697ab

Browse files
author
levkovskiy.dmitry
committed
Check that oldValue is instance of object before check by fields
1 parent ac125fd commit 8e697ab

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/core/watcher-helper.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,13 @@ export class WatcherHelper {
3939
}
4040

4141
private _isDifferentValues(oldValue: any, newValue: any, deepCheck: boolean) {
42-
if (deepCheck && newValue instanceof (Object)) {
42+
if (deepCheck && newValue instanceof (Object) && oldValue instanceof (Object)) {
4343
return this._checkObjectsFields(newValue, oldValue);
4444
}
4545
return oldValue !== newValue;
4646
}
4747

4848
private _checkObjectsFields(checkingFromObject: Object, checkingToObject: Object) {
49-
if (!(checkingFromObject && checkingToObject)) {
50-
return true;
51-
}
52-
5349
for (let field in checkingFromObject) {
5450
if (checkingFromObject[field] > checkingToObject[field] || checkingFromObject[field] < checkingToObject[field]) {
5551
return true;

0 commit comments

Comments
 (0)