Skip to content

Commit e92775a

Browse files
authored
Fix menu blinking on xs screens (#117)
1 parent 8650934 commit e92775a

File tree

2 files changed

+2
-19
lines changed

2 files changed

+2
-19
lines changed

templates/react/application/src/utils/patches.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
export function menuPreInitPatch(component) {
2-
const menuOpened = component.state.menuOpened;
2+
const { menuOpened, minMenuSize } = component.state;
33
component.state.preInitCssFix = true;
44
return {
55
get cssClass() {
6-
if (menuOpened) {
6+
if (menuOpened || minMenuSize === 0) {
77
return "";
88
}
99

testing/app-template.test.shared.js

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,6 @@ module.exports = (env) => {
8787
return;
8888
}
8989

90-
// TODO: Fix user panel and content shift in Reactin inner layout
91-
if(env.engine === 'react' && !isDefaultLayout && device.name === 'iPhone 5') {
92-
expect(true).toBe(true);
93-
return;
94-
}
95-
9690
const page = await openPage(appUrl);
9791
const image = await page.screenshot({
9892
clip: {
@@ -107,12 +101,6 @@ module.exports = (env) => {
107101
});
108102

109103
it('Profile view', async() => {
110-
// TODO: Fix user panel and content shift in Reactin inner layout
111-
if(env.engine === 'react' && !isDefaultLayout && device.name === 'iPhone 5') {
112-
expect(true).toBe(true);
113-
return;
114-
}
115-
116104
const page = await openPage(`${appUrl}#/profile`);
117105
const image = await page.screenshot();
118106

@@ -125,11 +113,6 @@ module.exports = (env) => {
125113
expect(true).toBe(true);
126114
return;
127115
}
128-
// TODO: Fix user panel and content shift in Reactin inner layout
129-
if(env.engine === 'react' && !isDefaultLayout && device.name === 'iPhone 5') {
130-
expect(true).toBe(true);
131-
return;
132-
}
133116

134117
const page = await openPage(`${appUrl}#/display-data`);
135118
// NOTE: Wait for the DataGrid is loaded

0 commit comments

Comments
 (0)