Skip to content

Commit e8694f0

Browse files
authored
Revert "Add allowRenderToDetachedTable flag" (#785)
* Revert "Add allowRenderToDetachedTable flag (#784)" This reverts commit a9e81f1. * Update package.json
1 parent a9e81f1 commit e8694f0

File tree

4 files changed

+3
-23
lines changed

4 files changed

+3
-23
lines changed

packages/devextreme-react-generator/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/devextreme-react-generator/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"author": "Developer Express Inc.",
33
"name": "devextreme-react-generator",
4-
"version": "1.3.3",
4+
"version": "1.3.4",
55
"description": "DevExtreme React UI and Visualization Components",
66
"repository": {
77
"type": "git",

packages/devextreme-react-generator/src/component-generator.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,6 @@ const USE_REQUEST_ANIMATION_FRAME: Set<string> = new Set([
9898
'dxDataGrid',
9999
]);
100100

101-
const USE_DETACHED_TABLE: Set<string> = new Set([
102-
'dxDataGrid',
103-
'dxTreeList',
104-
]);
105-
106101
function getIndent(indent: number) {
107102
return Array(indent * 2 + 1).join(' ');
108103
}
@@ -358,7 +353,6 @@ const renderComponent: (model: {
358353
renderedPropTypings?: string[];
359354
isPortalComponent?: boolean;
360355
useRequestAnimationFrameFlag?: boolean;
361-
allowRenderToDetachedTable?: boolean;
362356
typeParams: string[] | undefined;
363357
}) => string = createTempate(
364358
`class <#= it.className #>${TYPE_PARAMS_WITH_DEFAULTS} extends BaseComponent<React.PropsWithChildren<<#= it.optionsName #>${TYPE_PARAMS}>> {
@@ -373,10 +367,6 @@ const renderComponent: (model: {
373367
L1}protected useRequestAnimationFrameFlag = true;\n`
374368
+ '<#?#>'
375369

376-
+ `<#? it.allowRenderToDetachedTable #>${
377-
L1}protected allowRenderToDetachedTable = true;\n`
378-
+ '<#?#>'
379-
380370
+ `<#? it.isPortalComponent #>${
381371
L1}protected isPortalComponent = true;\n`
382372
+ '<#?#>'
@@ -610,7 +600,6 @@ function generate(component: IComponent): string {
610600
renderedPropTypings,
611601
expectedChildren: component.expectedChildren,
612602
useRequestAnimationFrameFlag: USE_REQUEST_ANIMATION_FRAME.has(widgetName),
613-
allowRenderToDetachedTable: USE_DETACHED_TABLE.has(widgetName),
614603
isPortalComponent: PORTAL_COMPONENTS.has(widgetName),
615604
typeParams: component.optionsTypeParams?.length ? component.optionsTypeParams : undefined,
616605
}),

packages/devextreme-react/src/core/component-base.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ abstract class ComponentBase<P extends IHtmlOptions> extends React.PureComponent
6767

6868
protected useRequestAnimationFrameFlag = false;
6969

70-
protected allowRenderToDetachedTable = false;
71-
7270
protected useDeferUpdateForTemplates = false;
7371

7472
constructor(props: P) {
@@ -118,18 +116,11 @@ abstract class ComponentBase<P extends IHtmlOptions> extends React.PureComponent
118116
element = element || this._element;
119117

120118
const config = this._getConfig();
121-
const initialOptions = this._optionsManager.getInitialOptions(config);
122-
const hasDetachedFlag = Object.keys(initialOptions).includes('allowRenderToDetachedTable');
123-
124-
if (!hasDetachedFlag && this.allowRenderToDetachedTable) {
125-
initialOptions.allowRenderToDetachedTable = true;
126-
}
127-
128119
this._instance = new this._WidgetClass(
129120
element,
130121
{
131122
templatesRenderAsynchronously: true,
132-
...initialOptions,
123+
...this._optionsManager.getInitialOptions(config),
133124
},
134125
);
135126

0 commit comments

Comments
 (0)