From 35430f202bf8a1a39e4290579f46ccc1f9b78492 Mon Sep 17 00:00:00 2001 From: Mikhail Preyskurantov <5574159+mpreyskurantov@users.noreply.github.com> Date: Fri, 28 Feb 2025 18:58:04 +0200 Subject: [PATCH 1/6] 'CardAnalytics' is defined but never used --- packages/vue/src/components/library/ticker-card.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/vue/src/components/library/ticker-card.vue b/packages/vue/src/components/library/ticker-card.vue index 867125c39..cc60e4ddc 100644 --- a/packages/vue/src/components/library/ticker-card.vue +++ b/packages/vue/src/components/library/ticker-card.vue @@ -30,7 +30,6 @@ import { formatPrice } from '@/utils/formatters'; import { Sales, SalesOrOpportunitiesByCategory } from '@/types/analytics'; import { computed, withDefaults } from 'vue'; -import CardAnalytics from '@/components/library/card-analytics.vue'; const props = withDefaults( defineProps<{ From cdd11dc49c595ef8e0a78c8fa11eaa459b366820 Mon Sep 17 00:00:00 2001 From: Mikhail Preyskurantov <5574159+mpreyskurantov@users.noreply.github.com> Date: Fri, 28 Feb 2025 19:08:51 +0200 Subject: [PATCH 2/6] Prop 'title' requires default value to be set (non optional, like in angular and react, plus another 'titleText' name in angular) --- packages/vue/src/components/library/ticker-card.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vue/src/components/library/ticker-card.vue b/packages/vue/src/components/library/ticker-card.vue index cc60e4ddc..95dc7f57d 100644 --- a/packages/vue/src/components/library/ticker-card.vue +++ b/packages/vue/src/components/library/ticker-card.vue @@ -35,7 +35,7 @@ const props = withDefaults( defineProps<{ icon: string, tone?: 'warning' | 'info', - title? : string, + title: string, data?: SalesOrOpportunitiesByCategory | Sales | null, total?: string | null, percentage: number, From b3bb58dec203f33942d46ff46ed620a036dd2555 Mon Sep 17 00:00:00 2001 From: Mikhail Preyskurantov <5574159+mpreyskurantov@users.noreply.github.com> Date: Fri, 28 Feb 2025 19:12:27 +0200 Subject: [PATCH 3/6] Unexpected console statement (github actions / aka eslint) --- packages/shell/copy-themes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shell/copy-themes.js b/packages/shell/copy-themes.js index fc68d692e..7e6d691c5 100644 --- a/packages/shell/copy-themes.js +++ b/packages/shell/copy-themes.js @@ -6,6 +6,6 @@ copyFile( join(__dirname, 'src', 'app', 'themes.json'), (err) => { if (err) throw err; - console.log('themes.json copied'); + console.log('themes.json copied'); // eslint-disable-line no-console }, ); From 8a2d2b0e0569a9ecd1ab3ead3852ca791dec28aa Mon Sep 17 00:00:00 2001 From: Mikhail Preyskurantov <5574159+mpreyskurantov@users.noreply.github.com> Date: Mon, 3 Mar 2025 20:29:24 +0200 Subject: [PATCH 4/6] Prop 'tone' requires default value to be set --- packages/vue/src/components/library/ticker-card.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vue/src/components/library/ticker-card.vue b/packages/vue/src/components/library/ticker-card.vue index 95dc7f57d..d8ec5f93c 100644 --- a/packages/vue/src/components/library/ticker-card.vue +++ b/packages/vue/src/components/library/ticker-card.vue @@ -34,7 +34,7 @@ import { computed, withDefaults } from 'vue'; const props = withDefaults( defineProps<{ icon: string, - tone?: 'warning' | 'info', + tone?: 'warning' | 'info' | undefined, title: string, data?: SalesOrOpportunitiesByCategory | Sales | null, total?: string | null, From 3fbe6fd08c01b6757100ce94e0638eeaaa1637c5 Mon Sep 17 00:00:00 2001 From: Mikhail Preyskurantov <5574159+mpreyskurantov@users.noreply.github.com> Date: Mon, 3 Mar 2025 20:43:08 +0200 Subject: [PATCH 5/6] Prop 'tone' requires default value to be set (undefined -> eslint) --- packages/vue/src/components/library/ticker-card.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vue/src/components/library/ticker-card.vue b/packages/vue/src/components/library/ticker-card.vue index d8ec5f93c..636726b45 100644 --- a/packages/vue/src/components/library/ticker-card.vue +++ b/packages/vue/src/components/library/ticker-card.vue @@ -34,7 +34,7 @@ import { computed, withDefaults } from 'vue'; const props = withDefaults( defineProps<{ icon: string, - tone?: 'warning' | 'info' | undefined, + tone?: 'warning' | 'info', // eslint-disable-line vue/require-default-prop title: string, data?: SalesOrOpportunitiesByCategory | Sales | null, total?: string | null, From 1b4bbd48975451c999fc6f3557402b4b07ccbbb7 Mon Sep 17 00:00:00 2001 From: Mikhail Preyskurantov <5574159+mpreyskurantov@users.noreply.github.com> Date: Mon, 10 Mar 2025 15:43:31 +0200 Subject: [PATCH 6/6] Prop 'tone' requires default value to be set (eslint -> defineProps) --- packages/vue/src/components/library/ticker-card.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/vue/src/components/library/ticker-card.vue b/packages/vue/src/components/library/ticker-card.vue index 636726b45..8eeba7b83 100644 --- a/packages/vue/src/components/library/ticker-card.vue +++ b/packages/vue/src/components/library/ticker-card.vue @@ -34,7 +34,7 @@ import { computed, withDefaults } from 'vue'; const props = withDefaults( defineProps<{ icon: string, - tone?: 'warning' | 'info', // eslint-disable-line vue/require-default-prop + tone?: 'warning' | 'info' title: string, data?: SalesOrOpportunitiesByCategory | Sales | null, total?: string | null, @@ -43,6 +43,7 @@ const props = withDefaults( { data: null, total: null, + tone: undefined, }, );