Fix paths filtering in the case of empty filter

Author: IlyaKhD

common/src/path-utils.test.ts

@@ -9,6 +9,11 @@ describe('path utils', () => {
                 patterns: [],
                 expected: []
             },
+            {
+                paths: ['a.ts', 'a.js', 'b.md'],
+                patterns: [],
+                expected: ['a.ts', 'a.js', 'b.md']
+            },
             {
                 paths: ['a.ts', 'a.js', 'b.md'],
                 patterns: ['b*.*'],

common/src/path-utils.ts

@@ -24,11 +24,13 @@ function filterPathsImpl(
     paths: string[],
     patterns: string[],
 ): string[] {
-    return paths.filter(path => {
-        return patterns.reduce((prevResult, pattern) => {
-            return pattern.startsWith(NEGATION)
-                ? prevResult && !match(path, pattern.substring(1))
-                : prevResult || match(path, pattern);
-        }, false);
-    });
+    return patterns?.length === 0
+        ? paths
+        : paths.filter(path => {
+            return patterns.reduce((prevResult, pattern) => {
+                return pattern.startsWith(NEGATION)
+                    ? prevResult && !match(path, pattern.substring(1))
+                    : prevResult || match(path, pattern);
+            }, false);
+        });
 }

get-changed-files/dist/index.js

@@ -144,13 +144,15 @@ function filterPaths(paths, patterns) {
 }
 exports.filterPaths = filterPaths;
 function filterPathsImpl(paths, patterns) {
-    return paths.filter(path => {
-        return patterns.reduce((prevResult, pattern) => {
-            return pattern.startsWith(NEGATION)
-                ? prevResult && !match(path, pattern.substring(1))
-                : prevResult || match(path, pattern);
-        }, false);
-    });
+    return (patterns === null || patterns === void 0 ? void 0 : patterns.length) === 0
+        ? paths
+        : paths.filter(path => {
+            return patterns.reduce((prevResult, pattern) => {
+                return pattern.startsWith(NEGATION)
+                    ? prevResult && !match(path, pattern.substring(1))
+                    : prevResult || match(path, pattern);
+            }, false);
+        });
 }
 
 

pr-filter/dist/index.js

@@ -144,13 +144,15 @@ function filterPaths(paths, patterns) {
 }
 exports.filterPaths = filterPaths;
 function filterPathsImpl(paths, patterns) {
-    return paths.filter(path => {
-        return patterns.reduce((prevResult, pattern) => {
-            return pattern.startsWith(NEGATION)
-                ? prevResult && !match(path, pattern.substring(1))
-                : prevResult || match(path, pattern);
-        }, false);
-    });
+    return (patterns === null || patterns === void 0 ? void 0 : patterns.length) === 0
+        ? paths
+        : paths.filter(path => {
+            return patterns.reduce((prevResult, pattern) => {
+                return pattern.startsWith(NEGATION)
+                    ? prevResult && !match(path, pattern.substring(1))
+                    : prevResult || match(path, pattern);
+            }, false);
+        });
 }
 
 

verify-version-change/dist/index.js

@@ -144,13 +144,15 @@ function filterPaths(paths, patterns) {
 }
 exports.filterPaths = filterPaths;
 function filterPathsImpl(paths, patterns) {
-    return paths.filter(path => {
-        return patterns.reduce((prevResult, pattern) => {
-            return pattern.startsWith(NEGATION)
-                ? prevResult && !match(path, pattern.substring(1))
-                : prevResult || match(path, pattern);
-        }, false);
-    });
+    return (patterns === null || patterns === void 0 ? void 0 : patterns.length) === 0
+        ? paths
+        : paths.filter(path => {
+            return patterns.reduce((prevResult, pattern) => {
+                return pattern.startsWith(NEGATION)
+                    ? prevResult && !match(path, pattern.substring(1))
+                    : prevResult || match(path, pattern);
+            }, false);
+        });
 }