Skip to content

Commit b56702e

Browse files
BayheckBayheck
andauthored
Removed unnecessary chrome switches (#8388)
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> ## Purpose Remove flags: '--disable-client-side-phishing-detection', - Removed in [HERE](https://issues.chromium.org/issues/41099515) '--disable-infobars', - Removed in [HERE](https://chromium.googlesource.com/chromium/src/+/d869ab3350d8ebd95222b4a47adf87ce3d3214b1) '--password-store=basic', '--use-mock-keychain', Tried to remove: '--enable-automation' (resize tests failed without it) ## Approach _Describe how your changes address the issue or implement the desired functionality in as much detail as possible._ ## References Closes DevExpress/testcafe-private#549 ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail --------- Co-authored-by: Bayheck <[email protected]>
1 parent c95923e commit b56702e

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/browser/provider/built-in/dedicated/chrome/build-chrome-args.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,10 @@ export function buildChromeArgs ({ config, cdpPort, platformArgs, tempProfileDir
1010
'--disable-background-timer-throttling',
1111
'--disable-backgrounding-occluded-windows',
1212
'--disable-breakpad',
13-
'--disable-client-side-phishing-detection',
1413
'--disable-default-apps',
1514
'--disable-extensions',
1615
'--disable-hang-monitor',
17-
'--disable-infobars',
1816
'--disable-ipc-flooding-protection',
19-
'--disable-popup-blocking',
2017
'--disable-prompt-on-repost',
2118
'--disable-renderer-backgrounding',
2219
'--disable-sync',
@@ -26,8 +23,6 @@ export function buildChromeArgs ({ config, cdpPort, platformArgs, tempProfileDir
2623
'--force-color-profile=srgb',
2724
'--metrics-recording-only',
2825
'--no-first-run',
29-
'--password-store=basic',
30-
'--use-mock-keychain',
3126
];
3227

3328
let chromeArgs = []

0 commit comments

Comments
 (0)