Use standard APIs available in modern Node.js and remove dev dependencies.

Author: DevHawkNov

changelog.md

@@ -5,6 +5,7 @@
 ### Major
 
 - Updated Node.js support to `^18.18.0 || ^20.9.0 || >=21.1.0`.
+- Refactored tests to use the standard `AbortController`, `AbortSignal`, `Event`, `EventTarget`, `File`, `FormData`, and `Response` APIs available in modern Node.js and removed the dev dependencies [`abort-controller`](https://npm.im/abort-controller), [`event-target-shim`](https://npm.im/event-target-shim), and [`node-fetch`](https://npm.im/node-fetch).
 
 ### Patch
 

fetchGraphQL.test.mjs

@@ -1,7 +1,6 @@
 // @ts-check
 
 import { deepStrictEqual, strictEqual } from "node:assert";
-import { Response } from "node-fetch";
 import revertableGlobals from "revertable-globals";
 
 import fetchGraphQL from "./fetchGraphQL.mjs";

fetchOptionsGraphQL.test.mjs

@@ -1,8 +1,6 @@
 // @ts-check
 
 import { deepStrictEqual, strictEqual } from "node:assert";
-import { File, FormData } from "node-fetch";
-import revertableGlobals from "revertable-globals";
 
 import fetchOptionsGraphQL from "./fetchOptionsGraphQL.mjs";
 import assertBundleSize from "./test/assertBundleSize.mjs";
@@ -32,35 +30,29 @@ export default (tests) => {
   });
 
   tests.add("`fetchOptionsGraphQL` with files.", () => {
-    const revertGlobals = revertableGlobals({ File, FormData });
-
-    try {
-      const fileName = "a.txt";
-      const options = fetchOptionsGraphQL({
-        query: "",
-        variables: { a: new File(["a"], fileName) },
-      });
+    const fileName = "a.txt";
+    const options = fetchOptionsGraphQL({
+      query: "",
+      variables: { a: new File(["a"], fileName) },
+    });
 
-      // See the GraphQL multipart request spec:
-      // https://github.com/jaydenseric/graphql-multipart-request-spec
+    // See the GraphQL multipart request spec:
+    // https://github.com/jaydenseric/graphql-multipart-request-spec
 
-      strictEqual(options.method, "POST");
-      deepStrictEqual(options.headers, { Accept: "application/json" });
-      assertInstanceOf(options.body, FormData);
+    strictEqual(options.method, "POST");
+    deepStrictEqual(options.headers, { Accept: "application/json" });
+    assertInstanceOf(options.body, FormData);
 
-      const formDataEntries = Array.from(options.body.entries());
+    const formDataEntries = Array.from(options.body.entries());
 
-      strictEqual(formDataEntries.length, 3);
-      deepStrictEqual(formDataEntries[0], [
-        "operations",
-        '{"query":"","variables":{"a":null}}',
-      ]);
-      deepStrictEqual(formDataEntries[1], ["map", '{"1":["variables.a"]}']);
-      strictEqual(formDataEntries[2][0], "1");
-      assertInstanceOf(formDataEntries[2][1], File);
-      strictEqual(formDataEntries[2][1].name, fileName);
-    } finally {
-      revertGlobals();
-    }
+    strictEqual(formDataEntries.length, 3);
+    deepStrictEqual(formDataEntries[0], [
+      "operations",
+      '{"query":"","variables":{"a":null}}',
+    ]);
+    deepStrictEqual(formDataEntries[1], ["map", '{"1":["variables.a"]}']);
+    strictEqual(formDataEntries[2][0], "1");
+    assertInstanceOf(formDataEntries[2][1], File);
+    strictEqual(formDataEntries[2][1].name, fileName);
   });
 };

package.json

@@ -109,16 +109,13 @@
     "@types/react": "^18.0.17",
     "@types/react-dom": "^18.0.6",
     "@types/react-test-renderer": "^18.0.0",
-    "abort-controller": "^3.0.0",
     "coverage-node": "^8.0.0",
     "esbuild": "^0.15.5",
     "eslint": "^8.23.0",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
-    "event-target-shim": "^6.0.2",
     "filter-console": "^1.0.0",
     "gzip-size": "^7.0.0",
-    "node-fetch": "^3.2.10",
     "prettier": "^2.7.1",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",

test.mjs

@@ -1,6 +1,7 @@
 // @ts-check
 
-import "./test/polyfills.mjs";
+import "./test/polyfillCustomEvent.mjs";
+import "./test/polyfillFile.mjs";
 
 import TestDirector from "test-director";
 

test/polyfillCustomEvent.mjs

@@ -0,0 +1,27 @@
+// @ts-check
+
+// TODO: Delete this polyfill once all supported Node.js versions have the
+// global `CustomEvent`:
+// https://nodejs.org/api/globals.html#customevent
+globalThis.CustomEvent ??=
+  /**
+   * `CustomEvent` polyfill.
+   * @template [T=unknown]
+   * @type {globalThis.CustomEvent<T>}
+   */
+  class CustomEvent extends Event {
+    /**
+     * @param {string} type Event type.
+     * @param {CustomEventInit<T>} [options] Custom event options.
+     */
+    constructor(type, options = {}) {
+      // Workaround a TypeScript bug:
+      // https://github.com/microsoft/TypeScript/issues/50286
+      const { detail, ...eventOptions } = options;
+      super(type, eventOptions);
+      if (detail) this.detail = detail;
+    }
+
+    /** @deprecated */
+    initCustomEvent() {}
+  };

test/polyfillFile.mjs

@@ -0,0 +1,9 @@
+// @ts-check
+
+import { File as NodeFile } from "node:buffer";
+
+// TODO: Delete this polyfill once all supported Node.js versions have the
+// global `File`:
+// https://nodejs.org/api/globals.html#class-file
+// @ts-expect-error It’s not a perfect polyfill, but works for the tests.
+globalThis.File ??= NodeFile;