Skip to content

Commit 81f5581

Browse files
thugheskartben
authored andcommitted
tests: kernel: thread_apis: Fix -Wsometimes-uninitialized warning
Building kernel.threads.apis with clang warns: tests/kernel/threads/thread_apis/src/main.c:362:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (m == ISR_ALREADY_EXIT || m == ISR_RUNNING) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tests/kernel/threads/thread_apis/src/main.c:380:6: note: uninitialized use occurs here if (ret != 0) { ^~~ tests/kernel/threads/thread_apis/src/main.c:362:2: note: remove the 'if' if its condition is always false if (m == ISR_ALREADY_EXIT || m == ISR_RUNNING) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tests/kernel/threads/thread_apis/src/main.c:362:6: error: variable 'ret' is used uninitialized whenever '||' condition is true [-Werror,-Wsometimes-uninitialized] if (m == ISR_ALREADY_EXIT || m == ISR_RUNNING) { ^~~~~~~~~~~~~~~~~~~~~ tests/kernel/threads/thread_apis/src/main.c:380:6: note: uninitialized use occurs here if (ret != 0) { ^~~ tests/kernel/threads/thread_apis/src/main.c:362:6: note: remove the '||' if its condition is always false if (m == ISR_ALREADY_EXIT || m == ISR_RUNNING) { ^~~~~~~~~~~~~~~~~~~~~~~~ tests/kernel/threads/thread_apis/src/main.c:329:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 Signed-off-by: Tom Hughes <[email protected]>
1 parent 7b09cce commit 81f5581

File tree

1 file changed

+1
-1
lines changed
  • tests/kernel/threads/thread_apis/src

1 file changed

+1
-1
lines changed

tests/kernel/threads/thread_apis/src/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ static void do_join_from_isr(const void *arg)
326326
static int join_scenario_interval(enum control_method m, int64_t *interval)
327327
{
328328
k_timeout_t timeout = K_FOREVER;
329-
int ret;
329+
int ret = 0;
330330

331331
LOG_DBG("ztest_thread: method %d, create join_thread", m);
332332
k_thread_create(&join_thread, join_stack, STACK_SIZE, join_entry,

0 commit comments

Comments
 (0)