Skip to content

Commit 73f8f2e

Browse files
committed
fix: close tabs in browesr
1 parent 349a637 commit 73f8f2e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

internal/web/web.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,10 @@ func BuildLauncher(ctx context.Context, conf *WebConfig) *launcher.Launcher {
100100
Leakless(conf.leakless)
101101

102102
if conf.CustomChromeExecutable != "" {
103-
fmt.Fprintf(os.Stderr, "browser: %s\n", conf.CustomChromeExecutable)
104103
return l.Bin(conf.CustomChromeExecutable)
105104
}
106105
// try default locations if custom location is not specified and default location exists
107106
if defaultExecPath, found := launcher.LookPath(); conf.CustomChromeExecutable == "" && defaultExecPath != "" && found {
108-
fmt.Fprintf(os.Stderr, "browser: %s\n", defaultExecPath)
109107
return l.Bin(defaultExecPath)
110108
}
111109
return l
@@ -123,7 +121,8 @@ func (web *Web) GetSamlLogin(conf credentialexchange.CredentialConfig) (string,
123121
// should cover most cases even with leakless: false
124122
defer web.MustClose()
125123

126-
web.browser.MustPage(conf.ProviderUrl)
124+
page := web.browser.MustPage(conf.ProviderUrl)
125+
defer page.MustClose()
127126

128127
router := web.browser.HijackRequests()
129128
defer router.MustStop()
@@ -177,7 +176,8 @@ func (web *Web) GetSSOCredentials(conf credentialexchange.CredentialConfig) (str
177176
// should cover most cases even with leakless: false
178177
defer web.MustClose()
179178

180-
web.browser.MustPage(conf.ProviderUrl)
179+
page := web.browser.MustPage(conf.ProviderUrl)
180+
defer page.MustClose()
181181

182182
router := web.browser.HijackRequests()
183183

0 commit comments

Comments
 (0)