fix: add more tests to sso edge case

Author: dnitsch

cmd/saml.go

@@ -232,10 +232,10 @@ func configValid(config *credentialexchange.CredentialConfig) error {
 		ssoVal = len(config.SsoRole) > 0 && len(config.SsoRegion) > 0
 	}
 	v.RequiredString(config.ProviderUrl, "provider-url", "provider url must be specified").
-		RequiredString(config.BaseConfig.Role, "role", "role must be provided").
+		// RequiredString(config.BaseConfig.Role, "role", "role must be provided").
 		RequiredString(config.PrincipalArn, "principal-arn", "principal ARN must be provided").
 		CustomRule(ssoVal, "is-sso", "sso-role must be specified when is-sso is set").
-		CustomRule((len(config.BaseConfig.Role) > 1 && len(config.SsoRole) < 1) || (len(config.BaseConfig.Role) < 1 && len(config.SsoRole) > 1), "sso-role", "sso-role cannot be specified when role is also set")
+		CustomRule((len(config.BaseConfig.Role) > 1 && len(config.SsoRole) < 1) || (len(config.BaseConfig.Role) < 1 && len(config.SsoRole) > 1), "role", "sso-role cannot be specified when role is also set")
 
 	if v.IsFailed() {
 		return fmt.Errorf("%w %#q", ErrValidationFailed, v.Errors())

cmd/saml_test.go

@@ -77,11 +77,12 @@ func Test_ConfigMerge_fails_with_missing(t *testing.T) {
 				RoleChain:             []string{"role-123"},
 			},
 			PrincipalArn: "some-arn",
-			SsoRegion:    "foo",
+			IsSso:        true,
+			SsoRegion:    "",
 			SsoRole:      "foo:bar",
 			ProviderUrl:  "https://my-idp.com/?app_id=testdd",
 		}
-		err := cmd.ConfigFromFlags(conf, &cmd.RootCmdFlags{}, &cmd.SamlCmdFlags{Role: "wrong-role"}, "me")
+		err := cmd.ConfigFromFlags(conf, &cmd.RootCmdFlags{}, &cmd.SamlCmdFlags{}, "me")
 		if !errors.Is(err, cmd.ErrValidationFailed) {
 			t.Error(err)
 		}