fix: saml sso-role validation (#11)

dnitsch · web-flow · commit fd871174008a · 2023-11-03T18:41:08.000Z
diff --git a/cmd/saml.go b/cmd/saml.go
@@ -91,7 +91,7 @@ func getSaml(cmd *cobra.Command, args []string) error {
 
 	if isSso {
 		sr := strings.Split(ssoRole, ":")
-		if len(sr) > 2 {
+		if len(sr) != 2 {
 			return fmt.Errorf("incorrectly formatted role for AWS SSO - must only be ACCOUNT:ROLE_NAME")
 		}
 		conf.SsoUserEndpoint = fmt.Sprintf("https://portal.sso.%s.amazonaws.com/user", conf.SsoRegion)

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func getSaml(cmd *cobra.Command, args []string) error {`
`91`	`91`
`92`	`92`	`if isSso {`
`93`	`93`	`sr := strings.Split(ssoRole, ":")`
`94`		`- if len(sr) > 2 {`
	`94`	`+ if len(sr) != 2 {`
`95`	`95`	`return fmt.Errorf("incorrectly formatted role for AWS SSO - must only be ACCOUNT:ROLE_NAME")`
`96`	`96`	`}`
`97`	`97`	`conf.SsoUserEndpoint = fmt.Sprintf("https://portal.sso.%s.amazonaws.com/user", conf.SsoRegion)`