Merge pull request #1 from DevNet-Framework/1.1

fix: deprecation warning of Implicitly marking parameters as nullable PHP 8.4

Author: Machometec

lib/Authentication/AuthenticationBuilder.php

@@ -18,7 +18,7 @@ class AuthenticationBuilder
 {
     private array $authentications;
 
-    public function addCookie(string $authenticationScheme = AuthenticationScheme::CookieSession, Closure $configuration = null): void
+    public function addCookie(string $authenticationScheme = AuthenticationScheme::CookieSession, ?Closure $configuration = null): void
     {
         $options = new AuthenticationCookieOptions();
         if ($configuration) {
@@ -28,7 +28,7 @@ public function addCookie(string $authenticationScheme = AuthenticationScheme::C
         $this->authentications[$authenticationScheme] = new AuthenticationCookieHandler($options);
     }
 
-    public function addJwtBearer(string $authenticationScheme = AuthenticationScheme::JwtBearer, Closure $configuration = null): void
+    public function addJwtBearer(string $authenticationScheme = AuthenticationScheme::JwtBearer, ?Closure $configuration = null): void
     {
         $options = new JwtBearerOptions();
         if ($configuration) {

lib/Claims/ClaimsIdentity.php

@@ -20,7 +20,7 @@ class ClaimsIdentity implements IEnumerable
     private ?string $authenticationType;
     private array $claims = [];
 
-    public function __construct(string $authenticationType = null, array $claims = [])
+    public function __construct(?string $authenticationType = null, array $claims = [])
     {
         $this->authenticationType = $authenticationType;
         $this->claims = $claims;

lib/Session.php

@@ -52,7 +52,6 @@ public function start(): void
         }
 
         $_COOKIE[$this->name] = $this->id;
-        //setcookie(session_name(), session_id(), time()+$lifetime);
         $this->set('SessionOptions', $this->options);
     }