Skip to content

Commit 718ce54

Browse files
committed
fix: deprecation warning of Implicitly marking parameters as nullable for PHP 8.4
1 parent 88e4c33 commit 718ce54

File tree

8 files changed

+14
-14
lines changed

8 files changed

+14
-14
lines changed

lib/Async/Task.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function get_IsCompleted(): bool
106106
return !$this->generator->valid();
107107
}
108108

109-
public function start(TaskScheduler $taskScheduler = null): void
109+
public function start(?TaskScheduler $taskScheduler = null): void
110110
{
111111
if ($this->status == TaskStatus::Running) {
112112
return;

lib/Command/CommandLine.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public function invoke(array $args): void
131131

132132
if ($input) {
133133
Console::$ForegroundColor = ConsoleColor::Red;
134-
Console::writeline("Unrecognized command or argument '{$input}', try '--help' option for usage information.");
134+
Console::writeLine("Unrecognized command or argument '{$input}', try '--help' option for usage information.");
135135
Console::resetColor();
136136
return;
137137
}

lib/Linq.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public static function join(IEnumerable $enumerable, $innerCollection, Closure $
9191
return Enumerable::join($enumerable, $innerCollection, $outerSelector, $innerSelector, $resultSelector);
9292
}
9393

94-
public static function count(IEnumerable $enumerable, Closure $predicate = null): int
94+
public static function count(IEnumerable $enumerable, ?Closure $predicate = null): int
9595
{
9696
$interfaces = class_implements($enumerable);
9797
if (in_array(IQueryable::class, $interfaces)) {
@@ -101,7 +101,7 @@ public static function count(IEnumerable $enumerable, Closure $predicate = null)
101101
return Enumerable::count($enumerable, $predicate);
102102
}
103103

104-
public static function max(IEnumerable $enumerable, Closure $predicate = null)
104+
public static function max(IEnumerable $enumerable, ?Closure $predicate = null)
105105
{
106106
$interfaces = class_implements($enumerable);
107107
if (in_array(IQueryable::class, $interfaces)) {
@@ -111,7 +111,7 @@ public static function max(IEnumerable $enumerable, Closure $predicate = null)
111111
return Enumerable::max($enumerable, $predicate);
112112
}
113113

114-
public static function min(IEnumerable $enumerable, Closure $predicate = null)
114+
public static function min(IEnumerable $enumerable, ?Closure $predicate = null)
115115
{
116116
$interfaces = class_implements($enumerable);
117117
if (in_array(IQueryable::class, $interfaces)) {

lib/Linq/Enumerable.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,19 @@ public static function skip(IEnumerable $enumerable, int $offset): TakeEnumerabl
6868
return $take->skip($offset);
6969
}
7070

71-
public static function count(IEnumerable $enumerable, Closure $predicate = null): int
71+
public static function count(IEnumerable $enumerable, ?Closure $predicate = null): int
7272
{
7373
$count = new CountEnumerable($enumerable);
7474
return $count->count($predicate);
7575
}
7676

77-
public static function max(IEnumerable $enumerable, Closure $predicate = null)
77+
public static function max(IEnumerable $enumerable, ?Closure $predicate = null)
7878
{
7979
$count = new CountEnumerable($enumerable);
8080
return $count->max($predicate);
8181
}
8282

83-
public static function min(IEnumerable $enumerable, Closure $predicate = null)
83+
public static function min(IEnumerable $enumerable, ?Closure $predicate = null)
8484
{
8585
$count = new CountEnumerable($enumerable);
8686
return $count->min($predicate);

lib/Linq/Enumerables/CountEnumerable.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function __construct(IEnumerable $enumerable)
2626
$this->enumerable = $enumerable;
2727
}
2828

29-
public function count(Closure $predicate = null): int
29+
public function count(?Closure $predicate = null): int
3030
{
3131
$count = 0;
3232
foreach ($this->enumerable as $element) {
@@ -42,7 +42,7 @@ public function count(Closure $predicate = null): int
4242
return $count;
4343
}
4444

45-
public function max(Closure $predicate = null)
45+
public function max(?Closure $predicate = null)
4646
{
4747
$value = null;
4848
foreach ($this->enumerable as $element) {
@@ -58,7 +58,7 @@ public function max(Closure $predicate = null)
5858
return $value;
5959
}
6060

61-
public function min(Closure $predicate = null)
61+
public function min(?Closure $predicate = null)
6262
{
6363
$value = null;
6464
foreach ($this->enumerable as $element) {

lib/Linq/Enumerables/GroupEnumerable.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class GroupEnumerable implements IEnumerable
2323
private array $array = [];
2424
private ?string $key;
2525

26-
public function __construct(IEnumerable $enumerable, string $key = null)
26+
public function __construct(IEnumerable $enumerable, ?string $key = null)
2727
{
2828
$this->enumerable = $enumerable;
2929
$this->key = $key;

lib/Process.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class Process
1616
private ?array $env;
1717
private $process;
1818

19-
public function __construct(?string $cwd = null, array $env = null)
19+
public function __construct(?string $cwd = null, ?array $env = null)
2020
{
2121
$this->descriptors = [
2222
["pipe", "r"],

lib/Text/StringBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public function append(string $value): StringBuilder
2828
return $this;
2929
}
3030

31-
public function appendLine(string $value = null): StringBuilder
31+
public function appendLine(?string $value = null): StringBuilder
3232
{
3333
$this->text .= $value . PHP_EOL;
3434
return $this;

0 commit comments

Comments
 (0)