Addresses with-heart's comments

Add typechain's generated types to git.
Rename to isLoading.

Author: embiem

frontend/.gitignore

@@ -23,5 +23,3 @@ yarn-debug.log*
 yarn-error.log*
 
 .next
-
-/types/ethers-contracts

frontend/_tests_/hooks/useDevNFTSupply.test.ts

@@ -21,9 +21,9 @@ test('should return correct supply values & transition loading state', async ()
 
   const { result, waitForValueToChange } = renderHook(() => useDevNFTSupply());
 
-  expect(result.current.loading).toBe(true);
-  await waitForValueToChange(() => result.current.loading);
-  expect(result.current.loading).toBe(false);
+  expect(result.current.isLoading).toBe(true);
+  await waitForValueToChange(() => result.current.isLoading);
+  expect(result.current.isLoading).toBe(false);
 
   expect(result.current.maxSupply).toBe(8000);
   expect(result.current.totalSupply).toBe(2345);
@@ -46,9 +46,9 @@ test('should correctly handle "all minted" state', async () => {
 
   const { result, waitForValueToChange } = renderHook(() => useDevNFTSupply());
 
-  expect(result.current.loading).toBe(true);
-  await waitForValueToChange(() => result.current.loading);
-  expect(result.current.loading).toBe(false);
+  expect(result.current.isLoading).toBe(true);
+  await waitForValueToChange(() => result.current.isLoading);
+  expect(result.current.isLoading).toBe(false);
 
   expect(result.current.maxSupply).toBe(8000);
   expect(result.current.totalSupply).toBe(8000);

frontend/src/components/DirectMint/DirectMintBox.tsx

@@ -18,7 +18,7 @@ import useDevNFTSupply from '../../hooks/useDevNFTSupply';
 // used on the minting page
 const DirectMintBox = () => {
   const { t } = useTranslation();
-  const { loading, remainingPublicSupply } = useDevNFTSupply();
+  const { isLoading, remainingPublicSupply } = useDevNFTSupply();
   return (
     <>
       <Container maxW="container.md" centerContent>
@@ -41,7 +41,7 @@ const DirectMintBox = () => {
             </Text>
             <Text fontSize={{ base: 'xs', sm: 'xl' }}>
               {t('remainingTokensText', {
-                remainingTokens: loading ? '...' : remainingPublicSupply,
+                remainingTokens: isLoading ? '...' : remainingPublicSupply,
               })}
             </Text>
             <DirectMint />

frontend/src/hooks/useDevNFTSupply.ts

@@ -67,7 +67,7 @@ export default function useDevNFTSupply() {
   }, []);
 
   return {
-    loading: totalSupply === -1 || lockedSupply === -1,
+    isLoading: totalSupply === -1 || lockedSupply === -1,
     // This is the amount of total minted DEV NFTs, same as calling `totalSupply()` on the contract
     totalSupply,
     // This is the amount of minted DEV NFTs that only the contract owner can mint (TokenIDs 7778-8000, incl.)