Clean up string formatting, move before/afterEach

Addresses feedback on the PR. Also adddresses (in comment) the fact that
we are not handling high number networks in hex, which is what comments
in the code of useWallet call for

Author: gjsyme

packages/hooks/src/hooks/useWallet.test.tsx

@@ -3,20 +3,20 @@ import { useWallet } from './useWallet';
 import { Provider } from '../Provider';
 import { renderHook } from '@testing-library/react-hooks';
 
-let windowSpy;
+describe('useWallet tests', () => {
+  let windowSpy;
 
-beforeEach(() => {
-  windowSpy = jest.spyOn(window, 'window', 'get');
-});
+  beforeEach(() => {
+    windowSpy = jest.spyOn(window, 'window', 'get');
+  });
 
-afterEach(() => {
-  windowSpy.mockRestore();
-});
+  afterEach(() => {
+    windowSpy.mockRestore();
+  });
 
-describe('useWallet tests', () => {
-  test('should use the wallet', () => {
+  test('should instantiate for valid input types', () => {
     const wrapper = ({ children }) => (
-      <Provider network={1} infuraId={'abc123'}>
+      <Provider network={1} infuraId="abc123">
         {children}
       </Provider>
     );
@@ -28,9 +28,9 @@ describe('useWallet tests', () => {
 
   // initially is chainId undefined / requires network per the argument
   test('should be able to switch networks', () => {
-    const testNetwork = 2;
+    const testNetwork = 111;
     const wrapper = ({ children }) => (
-      <Provider network={testNetwork} infuraId={'abc123'}>
+      <Provider network={testNetwork} infuraId="abc123">
         {children}
       </Provider>
     );
@@ -53,7 +53,12 @@ describe('useWallet tests', () => {
     expect(windowSpy).toHaveBeenCalled();
     expect(requestArgs).toStrictEqual({
       method: 'wallet_switchEthereumChain',
+      // this passes (for high number networks)
       params: [{ chainId: `0x${testNetwork}` }]
+      // The test should probably look like this
+      // if we are in fact converting network numbers to hex
+      // but fails with the current implementation
+      // params: [{ chainId: `0x${Number(testNetwork).toString(16)}` }]
     });
   });
 });