BUG: fix reference counting bug in __array_interface__ implementation (numpy#27249)

ngoldbaum · web-flow · commit 16d69968a957 · 2024-08-21T19:01:15.000+02:00
* BUG: fix reference counting bug in __array_interface__ implementation

* MAINT: only decref if the reference is valid
diff --git a/numpy/_core/src/multiarray/ctors.c b/numpy/_core/src/multiarray/ctors.c
@@ -2232,8 +2232,8 @@ PyArray_FromInterface(PyObject *origin)
                     Py_SETREF(dtype, new_dtype);
                 }
             }
+            Py_DECREF(descr);
         }
-        Py_DECREF(descr);
     }
     Py_CLEAR(attr);
 

Original file line number	Diff line number	Diff line change
`@@ -2232,8 +2232,8 @@ PyArray_FromInterface(PyObject *origin)`
`2232`	`2232`	`Py_SETREF(dtype, new_dtype);`
`2233`	`2233`	`}`
`2234`	`2234`	`}`
	`2235`	`+ Py_DECREF(descr);`
`2235`	`2236`	`}`
`2236`		`- Py_DECREF(descr);`
`2237`	`2237`	`}`
`2238`	`2238`	`Py_CLEAR(attr);`
`2239`	`2239`