Merge pull request numpy#26857 from DimitriPapadopoulos/24994

MAINT: Start applying ruff/Pycodestyle rules

Author: charris

.spin/cmds.py

@@ -1,8 +1,6 @@
 import os
 import shutil
 import pathlib
-import shutil
-import pathlib
 import importlib
 import subprocess
 
@@ -263,7 +261,7 @@ def test(ctx, pytest_args, markexpr, n_jobs, tests, verbose, *args, **kwargs):
     if (n_jobs != "1") and ('-n' not in pytest_args):
         pytest_args = ('-n', str(n_jobs)) + pytest_args
 
-    if tests and not ('--pyargs' in pytest_args):
+    if tests and '--pyargs' not in pytest_args:
         pytest_args = ('--pyargs', tests) + pytest_args
 
     if verbose:
@@ -774,7 +772,7 @@ def notes(ctx, version_override):
     # Check if `towncrier` is installed
     if not shutil.which("towncrier"):
         raise click.ClickException(
-            f"please install `towncrier` to use this command"
+            "please install `towncrier` to use this command"
         )
 
     click.secho(

benchmarks/asv_pip_nopep517.py

@@ -1,7 +1,8 @@
 """
 This file is used by asv_compare.conf.json.tpl.
 """
-import subprocess, sys
+import subprocess
+import sys
 # pip ignores '--global-option' when pep517 is enabled therefore we disable it.
 cmd = [sys.executable, '-mpip', 'wheel', '--no-use-pep517']
 try:

benchmarks/benchmarks/common.py

@@ -1,6 +1,5 @@
 import numpy as np
 import random
-import os
 from functools import lru_cache
 from pathlib import Path
 

doc/neps/conf.py

@@ -15,7 +15,6 @@
 # add these directories to sys.path here. If the directory is relative to the
 # documentation root, use os.path.abspath to make it absolute, like shown here.
 #
-import os
 from datetime import datetime
 # import sys
 # sys.path.insert(0, os.path.abspath('.'))

doc/neps/tools/build_index.py

@@ -19,7 +19,7 @@ def render(tpl_path, context):
 def nep_metadata():
     ignore = ('nep-template.rst')
     sources = sorted(glob.glob(r'nep-*.rst'))
-    sources = [s for s in sources if not s in ignore]
+    sources = [s for s in sources if s not in ignore]
 
     meta_re = r':([a-zA-Z\-]*): (.*)'
 
@@ -55,7 +55,7 @@ def nep_metadata():
                 f'    {tags["Title"]!r}')
 
         if tags['Status'] in ('Accepted', 'Rejected', 'Withdrawn'):
-            if not 'Resolution' in tags:
+            if 'Resolution' not in tags:
                 raise RuntimeError(
                     f'NEP {nr} is Accepted/Rejected/Withdrawn but '
                     'has no Resolution tag'
@@ -70,15 +70,15 @@ def nep_metadata():
 
     for nr, tags in neps.items():
         if tags['Status'] == 'Superseded':
-            if not 'Replaced-By' in tags:
+            if 'Replaced-By' not in tags:
                 raise RuntimeError(
                     f'NEP {nr} has been Superseded, but has no Replaced-By tag'
                 )
 
             replaced_by = int(re.findall(r'\d+', tags['Replaced-By'])[0])
             replacement_nep = neps[replaced_by]
 
-            if not 'Replaces' in replacement_nep:
+            if 'Replaces' not in replacement_nep:
                 raise RuntimeError(
                     f'NEP {nr} is superseded by {replaced_by}, but that NEP has '
                     f"no Replaces tag."

doc/preprocess.py

@@ -1,7 +1,5 @@
 #!/usr/bin/env python3
-import subprocess
 import os
-import sys
 from string import Template
 
 def main():

doc/source/conf.py

@@ -575,7 +575,7 @@ def linkcode_resolve(domain, info):
            numpy.__version__, fn, linespec)
 
 from pygments.lexers import CLexer
-from pygments.lexer import inherit, bygroups
+from pygments.lexer import inherit
 from pygments.token import Comment
 
 class NumPyLexer(CLexer):

doc/source/reference/simd/gen_features.py

@@ -1,7 +1,7 @@
 """
 Generate CPU features tables from CCompilerOpt
 """
-from os import sys, path
+from os import path
 from numpy.distutils.ccompiler_opt import CCompilerOpt
 
 class FakeCCompilerOpt(CCompilerOpt):

numpy/__init__.py

@@ -144,7 +144,7 @@
         frexp, from_dlpack, frombuffer, fromfile, fromfunction, fromiter,
         frompyfunc, fromstring, full, full_like, gcd, generic, geomspace,
         get_printoptions, getbufsize, geterr, geterrcall, greater,
-        greater_equal, half, heaviside, hstack, hypot, identity, iinfo, iinfo,
+        greater_equal, half, heaviside, hstack, hypot, identity, iinfo,
         indices, inexact, inf, inner, int16, int32, int64, int8, int_, intc,
         integer, intp, invert, is_busday, isclose, isdtype, isfinite,
         isfortran, isinf, isnan, isnat, isscalar, issubdtype, lcm, ldexp,

numpy/_build_utils/gcc_build_bitness.py

@@ -3,7 +3,7 @@
 """
 
 import re
-from subprocess import run, PIPE
+from subprocess import run
 
 
 def main():