MAINT: apply ruff/flake8-simplify rule SIM115

DimitriPapadopoulos · DimitriPapadopoulos · commit 549e3d6436a9 · 2024-07-06T16:01:31.000+02:00
SIM115 Use context handler for opening files
diff --git a/tools/c_coverage/c_coverage_report.py b/tools/c_coverage/c_coverage_report.py
@@ -54,25 +54,23 @@ def mark_line(self, lineno, as_func=None):
             line.add(as_func)
 
     def write_text(self, fd):
-        source = open(self.path, "r")
-        for i, line in enumerate(source):
-            if i + 1 in self.lines:
-                fd.write("> ")
-            else:
-                fd.write("! ")
-            fd.write(line)
-        source.close()
+        with open(self.path, "r") as source:
+            for i, line in enumerate(source):
+                if i + 1 in self.lines:
+                    fd.write("> ")
+                else:
+                    fd.write("! ")
+                fd.write(line)
 
     def write_html(self, fd):
-        source = open(self.path, 'r')
-        code = source.read()
-        lexer = CLexer()
-        formatter = FunctionHtmlFormatter(
-            self.lines,
-            full=True,
-            linenos='inline')
-        fd.write(highlight(code, lexer, formatter))
-        source.close()
+        with open(self.path, 'r') as source:
+            code = source.read()
+            lexer = CLexer()
+            formatter = FunctionHtmlFormatter(
+                self.lines,
+                full=True,
+                linenos='inline')
+            fd.write(highlight(code, lexer, formatter))
 
 
 class SourceFiles:
@@ -95,24 +93,24 @@ def clean_path(self, path):
 
     def write_text(self, root):
         for path, source in self.files.items():
-            fd = open(os.path.join(root, self.clean_path(path)), "w")
-            source.write_text(fd)
-            fd.close()
+            with open(os.path.join(root, self.clean_path(path)), "w") as fd:
+                source.write_text(fd)
 
     def write_html(self, root):
         for path, source in self.files.items():
-            fd = open(os.path.join(root, self.clean_path(path) + ".html"), "w")
-            source.write_html(fd)
-            fd.close()
+            with open(
+                os.path.join(root, self.clean_path(path) + ".html"), "w"
+            ) as fd:
+                source.write_html(fd)
 
-        fd = open(os.path.join(root, 'index.html'), 'w')
-        fd.write("<html>")
-        paths = sorted(self.files.keys())
-        for path in paths:
-            fd.write('<p><a href="%s.html">%s</a></p>' %
-                     (self.clean_path(path), escape(path[len(self.prefix):])))
-        fd.write("</html>")
-        fd.close()
+        with open(os.path.join(root, 'index.html'), 'w') as fd:
+            fd.write("<html>")
+            paths = sorted(self.files.keys())
+            for path in paths:
+                fd.write('<p><a href="%s.html">%s</a></p>' %
+                         (self.clean_path(path),
+                          escape(path[len(self.prefix):])))
+            fd.write("</html>")
 
 
 def collect_stats(files, fd, pattern):
@@ -164,9 +162,8 @@ def collect_stats(files, fd, pattern):
 
     files = SourceFiles()
     for log_file in args.callgrind_file:
-        log_fd = open(log_file, 'r')
-        collect_stats(files, log_fd, args.pattern)
-        log_fd.close()
+        with open(log_file, 'r') as log_fd:
+            collect_stats(files, log_fd, args.pattern)
 
     if not os.path.exists(args.directory):
         os.makedirs(args.directory)
