MNT: check for valid views by comparing with NPY_MIN_INTP

ngoldbaum · ngoldbaum · commit 54e3a83ff64c · 2024-04-01T14:36:33.000-06:00
diff --git a/numpy/_core/src/multiarray/ctors.c b/numpy/_core/src/multiarray/ctors.c
@@ -1928,7 +1928,7 @@ PyArray_FromArray(PyArrayObject *arr, PyArray_Descr *newtype, int flags)
     if (!copy) {
         npy_intp view_offset;
         npy_intp is_safe = PyArray_SafeCast(oldtype, newtype, &view_offset, NPY_NO_CASTING, 1);
-        copy = copy || !(is_safe && (view_offset == 0));
+        copy = copy || !(is_safe && (view_offset != NPY_MIN_INTP));
     }
 
     if (copy) {
diff --git a/numpy/_core/src/multiarray/multiarraymodule.c b/numpy/_core/src/multiarray/multiarraymodule.c
@@ -1594,7 +1594,7 @@ _array_fromobject_generic(
         oldtype = PyArray_DESCR(oparr);
         npy_intp view_offset;
         npy_intp is_safe = PyArray_SafeCast(oldtype, dtype, &view_offset, NPY_NO_CASTING, 1);
-        npy_intp view_safe = (is_safe && (view_offset == 0));
+        npy_intp view_safe = (is_safe && (view_offset != NPY_MIN_INTP));
         if (view_safe) {
             if (copy != NPY_COPY_ALWAYS && STRIDING_OK(oparr, order)) {
                 if (oldtype == dtype) {

Original file line number	Diff line number	Diff line change
`@@ -1928,7 +1928,7 @@ PyArray_FromArray(PyArrayObject arr, PyArray_Descr newtype, int flags)`
`1928`	`1928`	`if (!copy) {`
`1929`	`1929`	`npy_intp view_offset;`
`1930`	`1930`	`npy_intp is_safe = PyArray_SafeCast(oldtype, newtype, &view_offset, NPY_NO_CASTING, 1);`
`1931`		`- copy = copy \|\| !(is_safe && (view_offset == 0));`
	`1931`	`+ copy = copy \|\| !(is_safe && (view_offset != NPY_MIN_INTP));`
`1932`	`1932`	`}`
`1933`	`1933`
`1934`	`1934`	`if (copy) {`