Skip to content

Commit 610cbe4

Browse files
committed
MAINT: distutils: remove obsolete search for ecc executable
This is a very old name for the `icc` executable. The problem that triggered this change is that the `find_executable` calls to determine if the name is `icc` or `ecc` was done at import time, and after an unrelated change in Meson (related to `icc` though) started printing `log.warn` output from within `find_executable` to report that the icc/ecc executables weren't found. That looked like:: WARN: Could not locate executable icc WARN: Could not locate executable ecc That in turn seemed to (but didn't actually) affect an import test (`test_api_importable` in `numpy/tests/test_public_api.py`). Finally, the `ecc` name may simply be wrong, for example this is a compiler-like thing and the first hit when you search for `ecc` compiler: https://github.com/santerijps/ecc Long story short: this removes some obsolete code which can yield potentially confusing stdout output. [skip cirrus] [skip circle]
1 parent e5fccde commit 610cbe4

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

numpy/distutils/intelccompiler.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,7 @@ def __init__(self, verbose=0, dry_run=0, force=0):
3737

3838
class IntelItaniumCCompiler(IntelCCompiler):
3939
compiler_type = 'intele'
40-
41-
# On Itanium, the Intel Compiler used to be called ecc, let's search for
42-
# it (now it's also icc, so ecc is last in the search).
43-
for cc_exe in map(find_executable, ['icc', 'ecc']):
44-
if cc_exe:
45-
break
40+
cc_exe = 'icc'
4641

4742

4843
class IntelEM64TCCompiler(UnixCCompiler):

0 commit comments

Comments
 (0)