Skip to content

Commit 6a0d05c

Browse files
committed
DOC: add todo
1 parent 6e03b4f commit 6a0d05c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

numpy/_core/src/multiarray/mapping.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2092,7 +2092,8 @@ array_assign_subscript(PyArrayObject *self, PyObject *ind, PyObject *op)
20922092
/* May need a generic copy function (only for refs and odd sizes) */
20932093
NPY_ARRAYMETHOD_FLAGS transfer_flags;
20942094
npy_intp itemsize = PyArray_ITEMSIZE(self);
2095-
2095+
// TODO: the heuristic used here to determine the src_dtype might be subtly wrong
2096+
// for non-REFCHK user DTypes. See gh-27057 for the prior discussion about this.
20962097
if (PyArray_GetDTypeTransferFunction(
20972098
1, itemsize, itemsize,
20982099
allocated_array ? PyArray_DESCR(mit->extra_op) : PyArray_DESCR(self),

0 commit comments

Comments
 (0)