TYP: respond to review comments

Author: ngoldbaum

numpy/_core/defchararray.pyi

@@ -27,6 +27,7 @@ from numpy._typing import (
     _ArrayLikeStr_co as U_co,
     _ArrayLikeBytes_co as S_co,
     _ArrayLikeString_co as T_co,
+    _ArrayLikeAnyString_co as UST_co,
     _ArrayLikeInt_co as i_co,
     _ArrayLikeBool_co as b_co,
 )
@@ -96,6 +97,8 @@ _CharDType_co = TypeVar(
 )
 _CharArray: TypeAlias = chararray[tuple[int, ...], dtype[_SCT]]
 
+AR_T: TypeAlias = np.ndarray[_Shape, np.dtypes.StringDType]
+
 class chararray(ndarray[_ShapeType_co, _CharDType_co]):
     @overload
     def __new__(
@@ -561,35 +564,35 @@ def add(x1: U_co, x2: U_co) -> NDArray[np.str_]: ...
 @overload
 def add(x1: S_co, x2: S_co) -> NDArray[np.bytes_]: ...
 @overload
-def add(x1: T_co, x2: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def add(x1: T_co, x2: T_co) -> AR_T: ...
 
 @overload
 def multiply(a: U_co, i: i_co) -> NDArray[np.str_]: ...
 @overload
 def multiply(a: S_co, i: i_co) -> NDArray[np.bytes_]: ...
 @overload
-def multiply(a: T_co, i: i_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def multiply(a: T_co, i: i_co) -> AR_T: ...
 
 @overload
 def mod(a: U_co, value: Any) -> NDArray[np.str_]: ...
 @overload
 def mod(a: S_co, value: Any) -> NDArray[np.bytes_]: ...
 @overload
-def mod(a: T_co, value: Any) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def mod(a: T_co, value: Any) -> AR_T: ...
 
 @overload
 def capitalize(a: U_co) -> NDArray[str_]: ...
 @overload
 def capitalize(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def capitalize(a: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def capitalize(a: T_co) -> AR_T: ...
 
 @overload
 def center(a: U_co, width: i_co, fillchar: U_co = ...) -> NDArray[str_]: ...
 @overload
 def center(a: S_co, width: i_co, fillchar: S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def center(a: T_co, width: i_co, fillchar: T_co = ...) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def center(a: T_co, width: i_co, fillchar: T_co = ...) -> AR_T: ...
 
 def decode(
     a: S_co,
@@ -607,42 +610,42 @@ def expandtabs(a: U_co, tabsize: i_co = ...) -> NDArray[str_]: ...
 @overload
 def expandtabs(a: S_co, tabsize: i_co = ...) -> NDArray[bytes_]: ...
 @overload
-def expandtabs(a: T_co, tabsize: i_co = ...) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def expandtabs(a: T_co, tabsize: i_co = ...) -> AR_T: ...
 
 @overload
 def join(sep: U_co, seq: U_co) -> NDArray[str_]: ...
 @overload
 def join(sep: S_co, seq: S_co) -> NDArray[bytes_]: ...
 @overload
-def join(sep: T_co, seq: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def join(sep: T_co, seq: T_co) -> AR_T: ...
 
 @overload
 def ljust(a: U_co, width: i_co, fillchar: U_co = ...) -> NDArray[str_]: ...
 @overload
 def ljust(a: S_co, width: i_co, fillchar: S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def ljust(a: T_co, width: i_co, fillchar: T_co = ...) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def ljust(a: T_co, width: i_co, fillchar: T_co = ...) -> AR_T: ...
 
 @overload
 def lower(a: U_co) -> NDArray[str_]: ...
 @overload
 def lower(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def lower(a: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def lower(a: T_co) -> AR_T: ...
 
 @overload
 def lstrip(a: U_co, chars: None | U_co = ...) -> NDArray[str_]: ...
 @overload
 def lstrip(a: S_co, chars: None | S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def lstrip(a: T_co, chars: None | T_co = ...) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def lstrip(a: T_co, chars: None | T_co = ...) -> AR_T: ...
 
 @overload
 def partition(a: U_co, sep: U_co) -> NDArray[str_]: ...
 @overload
 def partition(a: S_co, sep: S_co) -> NDArray[bytes_]: ...
 @overload
-def partition(a: T_co, sep: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def partition(a: T_co, sep: T_co) -> AR_T: ...
 
 @overload
 def replace(
@@ -664,7 +667,7 @@ def replace(
     old: T_co,
     new: T_co,
     count: i_co = ...,
-) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+) -> AR_T: ...
 
 @overload
 def rjust(
@@ -683,14 +686,14 @@ def rjust(
     a: T_co,
     width: i_co,
     fillchar: T_co = ...,
-) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+) -> AR_T: ...
 
 @overload
 def rpartition(a: U_co, sep: U_co) -> NDArray[str_]: ...
 @overload
 def rpartition(a: S_co, sep: S_co) -> NDArray[bytes_]: ...
 @overload
-def rpartition(a: T_co, sep: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def rpartition(a: T_co, sep: T_co) -> AR_T: ...
 
 @overload
 def rsplit(
@@ -709,14 +712,14 @@ def rsplit(
     a: T_co,
     sep: None | T_co = ...,
     maxsplit: None | i_co = ...,
-) -> NDArray[np.object_]: ...
+) -> NDArray[object_]: ...
 
 @overload
 def rstrip(a: U_co, chars: None | U_co = ...) -> NDArray[str_]: ...
 @overload
 def rstrip(a: S_co, chars: None | S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def rstrip(a: T_co, chars: None | T_co = ...) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def rstrip(a: T_co, chars: None | T_co = ...) -> AR_T: ...
 
 @overload
 def split(
@@ -735,64 +738,64 @@ def split(
     a: T_co,
     sep: None | T_co = ...,
     maxsplit: None | i_co = ...,
-) -> NDArray[np.object_]: ...
+) -> NDArray[object_]: ...
 
 @overload
-def splitlines(a: U_co | S_co | T_co, keepends: None | b_co = ...) -> NDArray[np.object_]: ...
+def splitlines(a: UST_co, keepends: None | b_co = ...) -> NDArray[np.object_]: ...
 
 @overload
 def strip(a: U_co, chars: None | U_co = ...) -> NDArray[str_]: ...
 @overload
 def strip(a: S_co, chars: None | S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def strip(a: T_co, chars: None | T_co = ...) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def strip(a: T_co, chars: None | T_co = ...) -> AR_T: ...
 
 @overload
 def swapcase(a: U_co) -> NDArray[str_]: ...
 @overload
 def swapcase(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def swapcase(a: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def swapcase(a: T_co) -> AR_T: ...
 
 @overload
 def title(a: U_co) -> NDArray[str_]: ...
 @overload
 def title(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def title(a: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def title(a: T_co) -> AR_T: ...
 
 @overload
 def translate(
     a: U_co,
-    table: U_co,
-    deletechars: None | U_co = ...,
+    table: str,
+    deletechars: None | str = ...,
 ) -> NDArray[str_]: ...
 @overload
 def translate(
     a: S_co,
-    table: S_co,
-    deletechars: None | S_co = ...,
+    table: str,
+    deletechars: None | str = ...,
 ) -> NDArray[bytes_]: ...
 @overload
 def translate(
     a: T_co,
-    table: T_co,
-    deletechars: None | T_co = ...,
-) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+    table: str,
+    deletechars: None | str = ...,
+) -> AR_T: ...
 
 @overload
 def upper(a: U_co) -> NDArray[str_]: ...
 @overload
 def upper(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def upper(a: T_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def upper(a: T_co) -> AR_T: ...
 
 @overload
 def zfill(a: U_co, width: i_co) -> NDArray[str_]: ...
 @overload
 def zfill(a: S_co, width: i_co) -> NDArray[bytes_]: ...
 @overload
-def zfill(a: T_co, width: i_co) -> np.ndarray[_Shape, np.dtypes.StringDType]: ...
+def zfill(a: T_co, width: i_co) -> AR_T: ...
 
 # String information
 @overload
@@ -883,15 +886,15 @@ def index(
     end: i_co | None = ...,
 ) -> NDArray[np.int_]: ...
 
-def isalpha(a: U_co | S_co | T_co) -> NDArray[np.bool]: ...
-def isalnum(a: U_co | S_co | T_co) -> NDArray[np.bool]: ...
+def isalpha(a: UST_co) -> NDArray[np.bool]: ...
+def isalnum(a: UST_co) -> NDArray[np.bool]: ...
 def isdecimal(a: U_co | T_co) -> NDArray[np.bool]: ...
-def isdigit(a: U_co | S_co | T_co) -> NDArray[np.bool]: ...
-def islower(a: U_co | S_co | T_co) -> NDArray[np.bool]: ...
+def isdigit(a: UST_co) -> NDArray[np.bool]: ...
+def islower(a: UST_co) -> NDArray[np.bool]: ...
 def isnumeric(a: U_co | T_co) -> NDArray[np.bool]: ...
-def isspace(a: U_co | S_co | T_co) -> NDArray[np.bool]: ...
-def istitle(a: U_co | S_co | T_co) -> NDArray[np.bool]: ...
-def isupper(a: U_co | S_co | T_co) -> NDArray[np.bool]: ...
+def isspace(a: UST_co) -> NDArray[np.bool]: ...
+def istitle(a: UST_co) -> NDArray[np.bool]: ...
+def isupper(a: UST_co) -> NDArray[np.bool]: ...
 
 @overload
 def rfind(
@@ -959,7 +962,7 @@ def startswith(
     end: i_co | None = ...,
 ) -> NDArray[np.bool]: ...
 
-def str_len(A: U_co | S_co | T_co) -> NDArray[int_]: ...
+def str_len(A: UST_co) -> NDArray[int_]: ...
 
 # Overload 1 and 2: str- or bytes-based array-likes
 # overload 3: arbitrary object with unicode=False  (-> bytes_)