Fixed popup menu not reloading when canvas patched. Fixed styles still applying if feature got disabled.

Author: Developer-Mike

src/canvas-extensions/interaction-tagger-canvas-extension.ts

@@ -1,5 +1,5 @@
 import { Canvas, CanvasNode } from "src/@types/Canvas"
-import { EXPOSED_DATA } from "./node-data-tagger-canvas-extension"
+import { getExposedNodeData } from "./node-data-tagger-canvas-extension"
 import AdvancedCanvasPlugin from "src/main"
 import { CanvasEvent } from "src/events/events"
 
@@ -18,7 +18,7 @@ export default class InteractionTaggerCanvasExtension {
         const interactionEl = canvas.nodeInteractionLayer.interactionEl
         if (!interactionEl) return
 
-        for (const dataKey of EXPOSED_DATA) {
+        for (const dataKey of getExposedNodeData(this.plugin.settingsManager)) {
           const datasetKey = TARGET_NODE_DATASET_PREFIX + dataKey.toString().charAt(0).toUpperCase() + dataKey.toString().slice(1)
 
           const dataValue = node?.getData()[dataKey]

src/canvas-extensions/node-data-tagger-canvas-extension.ts

@@ -1,8 +1,18 @@
 import { Canvas, CanvasNode, CanvasNodeData } from "src/@types/Canvas"
 import { CanvasEvent } from "src/events/events"
 import AdvancedCanvasPlugin from "src/main"
+import AdvancedCanvasSettingsManager from "src/settings"
 
-export const EXPOSED_DATA = ['type', 'shape', 'isStartNode', 'portalToFile', 'portalId'] as (keyof CanvasNodeData)[]
+export function getExposedNodeData(settings: AdvancedCanvasSettingsManager): (keyof CanvasNodeData)[] {
+  const exposedData: (keyof CanvasNodeData)[] = []
+
+  exposedData.push('type')
+  if (settings.getSetting('shapesFeatureEnabled')) exposedData.push('shape')
+  if (settings.getSetting('presentationFeatureEnabled')) exposedData.push('isStartNode')
+  if (settings.getSetting('portalsFeatureEnabled')) exposedData.push('portalToFile', 'portalId')
+
+  return exposedData
+}
 
 export default class NodeDataTaggerCanvasExtension {
   plugin: AdvancedCanvasPlugin
@@ -17,7 +27,7 @@ export default class NodeDataTaggerCanvasExtension {
           const nodeData = node?.getData()
           if (!nodeData) continue
 
-          for (const dataKey of EXPOSED_DATA) {
+          for (const dataKey of getExposedNodeData(this.plugin.settingsManager)) {
             const dataValue = nodeData[dataKey]
 
             if (dataValue === undefined) delete node.nodeEl.dataset[dataKey]

src/events/canvas-event-emitter.ts

@@ -157,6 +157,9 @@ export default class CanvasEventEmitter {
         // Re-init the canvas with the patched canvas object
         const canvasView = leaf.view as CanvasView
         canvasView.setViewData(canvasView.getViewData())
+
+        // Trigger popup menu changed event
+        this.triggerWorkspaceEvent(CanvasEvent.PopupMenuCreated, canvasView.canvas)
       })
 
       if (!canvasPatched) return