Fixed various issues and made more features optional

Author: Developer-Mike

src/canvas-extensions/dataset-exposers/canvas-metadata-exposer.ts

@@ -18,7 +18,7 @@ export default class CanvasMetadataExposerExtension extends CanvasExtension {
 
   private updateExposedSettings(canvas: Canvas) {
     // Expose start node
-    const startNodeId = canvas.getMetadata('startNode')
+    const startNodeId = canvas.metadata['startNode']
     for (const [nodeId, node] of canvas.nodes) {
       if (nodeId === startNodeId) node.nodeEl.dataset.isStartNode = 'true'
       else delete node.nodeEl.dataset.isStartNode

src/canvas-extensions/frontmatter-modal-canvas-extension.ts renamed to src/canvas-extensions/frontmatter-control-button-canvas-extension.ts

@@ -3,7 +3,7 @@ import CanvasExtension from "./canvas-extension"
 import CanvasHelper from "src/utils/canvas-helper"
 import { Notice } from "obsidian"
 
-export default class FrontmatterModalCanvasExtension extends CanvasExtension {
+export default class FrontmatterControlButtonCanvasExtension extends CanvasExtension {
   isEnabled() { return 'canvasMetadataCompatibilityEnabled' as const }
 
   init() {

src/canvas-extensions/presentation-canvas-extension.ts

@@ -154,7 +154,7 @@ export default class PresentationCanvasExtension extends CanvasExtension {
 
   private setStartNode(canvas: Canvas, node: CanvasNode | undefined) {
     if (!node) return
-    canvas.setMetadata('startNode', node.getData().id)
+    canvas.metadata['startNode'] = node.getData().id
   }
 
   private getDefaultSlideSize(): Size {
@@ -169,7 +169,7 @@ export default class PresentationCanvasExtension extends CanvasExtension {
   }
 
   private addSlide(canvas: Canvas, pos?: Position, bbox?: BBox) {
-    const isStartNode = canvas.getMetadata('startNode') === undefined
+    const isStartNode = canvas.metadata['startNode'] === undefined
     const slideSize = this.getDefaultSlideSize()
     const slideAspectRatio = this.getSlideAspectRatio()
 
@@ -207,7 +207,7 @@ export default class PresentationCanvasExtension extends CanvasExtension {
       ratio: slideAspectRatio
     })
 
-    if (isStartNode) canvas.setMetadata('startNode', groupNode.getData().id)
+    if (isStartNode) canvas.metadata['startNode'] = groupNode.getData().id
   }
 
   private async animateNodeTransition(canvas: Canvas, fromNode: CanvasNode|undefined, toNode: CanvasNode) {
@@ -244,7 +244,7 @@ export default class PresentationCanvasExtension extends CanvasExtension {
   private async startPresentation(canvas: Canvas, tryContinue: boolean = false) {
     // Only reset visited nodes if we are not trying to continue
     if (!tryContinue || this.visitedNodeIds.length === 0) {
-      const startNode = canvas.getMetadata('startNode') && canvas.nodes.get(canvas.getMetadata('startNode'))
+      const startNode = canvas.metadata['startNode'] && canvas.nodes.get(canvas.metadata['startNode'])
       if (!startNode) {
         new Notice('No start node found. Please mark a node as a start node trough the popup menu.')
         return

src/main.ts

@@ -34,7 +34,7 @@ import EncapsulateCanvasExtension from './canvas-extensions/encapsulate-canvas-e
 import CommandsCanvasExtension from './canvas-extensions/commands-canvas-extension'
 import AutoResizeNodeCanvasExtension from './canvas-extensions/auto-resize-node-canvas-extension'
 import PortalsCanvasExtension from './canvas-extensions/portals-canvas-extension'
-import FrontmatterModalCanvasExtension from './canvas-extensions/frontmatter-modal-canvas-extension'
+import FrontmatterControlButtonCanvasExtension from './canvas-extensions/frontmatter-control-button-canvas-extension'
 import BetterDefaultSettingsCanvasExtension from './canvas-extensions/better-default-settings-canvas-extension'
 import ColorPaletteCanvasExtension from './canvas-extensions/color-palette-canvas-extension'
 import CollapsibleGroupsCanvasExtension from './canvas-extensions/collapsible-groups-canvas-extension'
@@ -48,6 +48,7 @@ import NodeStylesExtension from './canvas-extensions/advanced-styles/node-styles
 import EdgeStylesExtension from './canvas-extensions/advanced-styles/edge-styles'
 
 // Dataset Exposers
+import CanvasMetadataExposerExtension from './canvas-extensions/dataset-exposers/canvas-metadata-exposer'
 import NodeInteractionExposerExtension from './canvas-extensions/dataset-exposers/node-interaction-exposer'
 import NodeExposerExtension from './canvas-extensions/dataset-exposers/node-exposer'
 import EdgeExposerExtension from './canvas-extensions/dataset-exposers/edge-exposer'
@@ -79,12 +80,13 @@ const CANVAS_EXTENSIONS: typeof CanvasExtension[] = [
   PortalsCanvasExtension,
 
   // UI Extensions (Non-savable data)
+  CanvasMetadataExposerExtension,
   CanvasWrapperExposerExtension,
   NodeExposerExtension,
   EdgeExposerExtension,
   NodeInteractionExposerExtension,
 
-  FrontmatterModalCanvasExtension,
+  FrontmatterControlButtonCanvasExtension,
   BetterDefaultSettingsCanvasExtension,
   CommandsCanvasExtension,
   BetterReadonlyCanvasExtension,

src/settings.ts

@@ -135,10 +135,10 @@ export const DEFAULT_SETTINGS_VALUES: AdvancedCanvasPluginSettingsValues = {
 
   variableBreakpointFeatureEnabled: false,
 
-  zOrderingControlFeatureEnabled: true,
+  zOrderingControlFeatureEnabled: false,
   zOrderingControlShowOneLayerShiftOptions: false,
 
-  aspectRatioControlFeatureEnabled: true,
+  aspectRatioControlFeatureEnabled: false,
 
   commandsFeatureEnabled: true,
   zoomToClonedNode: true,
@@ -154,7 +154,7 @@ export const DEFAULT_SETTINGS_VALUES: AdvancedCanvasPluginSettingsValues = {
 
   betterExportFeatureEnabled: true,
 
-  betterReadonlyEnabled: true,
+  betterReadonlyEnabled: false,
   hideBackgroundGridWhenInReadonly: true,
   disableNodePopup: false,
   disableZoom: false,
@@ -168,7 +168,7 @@ export const DEFAULT_SETTINGS_VALUES: AdvancedCanvasPluginSettingsValues = {
   collapsibleGroupsFeatureEnabled: true,
   collapsedGroupPreviewOnDrag: true,
 
-  focusModeFeatureEnabled: true,
+  focusModeFeatureEnabled: false,
 
   presentationFeatureEnabled: true,
   showSetStartNodeInPopup: false,
@@ -182,7 +182,7 @@ export const DEFAULT_SETTINGS_VALUES: AdvancedCanvasPluginSettingsValues = {
   slideTransitionAnimationDuration: 0.5,
   slideTransitionAnimationIntensity: 1.25,
 
-  canvasEncapsulationEnabled: true,
+  canvasEncapsulationEnabled: false,
 
   portalsFeatureEnabled: true,
   showEdgesIntoDisabledPortals: true

src/styles/settings.scss

@@ -27,9 +27,19 @@
   }
 }
 
+.settings-header-children {
+  transform-origin: top center;
+
+  transform: scaleY(1);
+  transition: transform 0.2s ease-in-out;
+}
+
 .ac-settings-heading:has(.checkbox-container:not(.is-enabled)) + .settings-header-children {
   opacity: 0.5;
   pointer-events: none;
+
+  height: 0;
+  transform: scaleY(0);
 }
 
 details.setting-item {
@@ -130,18 +140,4 @@ body.is-mobile .kofi-button.sticky {
   .no-button {
     cursor: pointer;
   }
-}
-
-// Quicksettings
-.quicksettings-suggestion {
-  display: flex;
-  flex-direction: column;
-
-  .quicksettings-suggestion-label {
-    font-weight: 500;
-  }
-  
-  .quicksettings-suggestion-description {
-    color: var(--text-muted);
-  }
 }