fix: liniting errors

Author: Nazzcodek

Makefile

@@ -216,4 +216,16 @@ check-patterns:
 
 check-queues:
 	@echo "📬 RabbitMQ queues:"
-	docker compose exec rabbitmq rabbitmqctl list_queues name messages
+	docker compose exec rabbitmq rabbitmqctl list_queues name messages
+
+lint:
+	@echo "detecting linting errors"
+	ruff check .
+
+lint-fix:
+	@echo "fixing linting errors"
+	ruff check . --fix
+
+lint-format:
+	@echo "formatting code block"
+	ruff format .

app/api/logs.py

@@ -10,13 +10,13 @@
 """
 
 from datetime import datetime, timedelta
-from typing import Optional, Dict, Any
+from typing import Optional
 from uuid import UUID
 
 from fastapi import APIRouter, Depends, HTTPException, Query, status
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from app.core.auth_external import get_current_user, get_current_user_optional
+from app.core.auth_external import get_current_user
 from app.core.logging import get_logger
 from app.db.session import get_db
 from app.schemas.log_schemas import (
@@ -44,10 +44,10 @@ async def get_logs(
 ) -> LogListResponse:
     """
     Retrieve processed logs with filtering and pagination.
-    
+
     **Purpose**: Monitoring and debugging only.
     **Note**: Log analysis happens automatically via RabbitMQ.
-    
+
     Requires JWT authentication.
     """
     log_service = LogService(db)
@@ -82,9 +82,9 @@ async def get_log(
 ) -> LogEntryResponse:
     """
     Retrieve a specific log entry by ID.
-    
+
     **Purpose**: Debugging and detailed investigation.
-    
+
     Requires JWT authentication.
     """
     log_service = LogService(db)
@@ -105,12 +105,12 @@ async def get_ai_status(
 ) -> APIResponse:
     """
     Get current AI processing status and configuration.
-    
+
     Returns:
     - AI enabled status (if disabled, system uses basic analysis)
     - Configuration details
     - Processing mode
-    
+
     Note: When AI fails, system automatically falls back to basic analysis.
     """
     settings = get_settings()
@@ -119,7 +119,9 @@ async def get_ai_status(
     return APIResponse(
         data={
             "ai_enabled": ai_enabled,
-            "processing_mode": "AI with automatic fallback" if ai_enabled else "Basic analysis only",
+            "processing_mode": (
+                "AI with automatic fallback" if ai_enabled else "Basic analysis only"
+            ),
             "ai_timeout_seconds": getattr(settings, 'ai_timeout_seconds', 10),
             "ai_retry_attempts": getattr(settings, 'ai_retry_attempts', 2),
             "ai_confidence_threshold": getattr(settings, 'ai_confidence_threshold', 0.5),
@@ -138,13 +140,13 @@ async def toggle_ai_processing(
 ) -> APIResponse:
     """
     Toggle AI processing on/off.
-    
+
     This endpoint allows you to:
     - Enable AI processing: Uses AI analysis with automatic fallback to basic analysis if AI fails
     - Disable AI processing: Uses only basic analysis
-    
+
     Changes are applied immediately to new log processing.
-    
+
     Note: Fallback to basic analysis is ALWAYS enabled when AI is on.
     When AI fails, the system automatically uses basic analysis to ensure continuous operation.
     """
@@ -155,16 +157,23 @@ async def toggle_ai_processing(
     logger.info(
         "ai_processing_toggled",
         ai_enabled=enable_ai,
-        processing_mode="AI with automatic fallback" if enable_ai else "Basic analysis only",
+        processing_mode=(
+            "AI with automatic fallback" if enable_ai else "Basic analysis only"
+        ),
         user=current_user.get("sub", "unknown"),
     )
 
     return APIResponse(
         data={
             "ai_enabled": enable_ai,
-            "processing_mode": "AI with automatic fallback" if enable_ai else "Basic analysis only",
+            "processing_mode": (
+                "AI with automatic fallback" if enable_ai else "Basic analysis only"
+            ),
             "message": f"AI processing {'enabled' if enable_ai else 'disabled'} successfully",
-            "note": "Fallback to basic analysis is automatic when AI fails. Changes apply to new log processing.",
+            "note": (
+                "Fallback to basic analysis is automatic when AI fails. "
+                "Changes apply to new log processing."
+            ),
         },
         status_code=200,
         message=f"AI processing {'enabled' if enable_ai else 'disabled'}",
@@ -178,7 +187,7 @@ async def get_processing_stats(
 ) -> APIResponse:
     """
     Get processing statistics and system metrics.
-    
+
     Returns:
     - Total logs processed
     - Logs by level (last 24 hours)
@@ -193,31 +202,31 @@ async def get_processing_stats(
     # Get logs by level (last 24 hours)
     end_date = datetime.utcnow()
     start_date = end_date - timedelta(hours=24)
-    
+
     _, error_count = await log_service.get_logs(
         log_level="ERROR",
         start_date=start_date,
         end_date=end_date,
         limit=1
     )
-    
+
     _, warning_count = await log_service.get_logs(
         log_level="WARNING",
         start_date=start_date,
         end_date=end_date,
         limit=1
     )
-    
+
     _, info_count = await log_service.get_logs(
         log_level="INFO",
         start_date=start_date,
         end_date=end_date,
         limit=1
     )
-    
+
     total_24h = error_count + warning_count + info_count
     error_rate = (error_count / total_24h * 100) if total_24h > 0 else 0
-    
+
     return APIResponse(
         data={
             "total_logs": total_logs,
@@ -230,9 +239,11 @@ async def get_processing_stats(
             },
             "processing_status": {
                 "ai_enabled": getattr(get_settings(), 'ai_analysis_enabled', True),
-                "real_time_processing": getattr(get_settings(), 'enable_real_time_processing', True),
+                "real_time_processing": getattr(
+                    get_settings(), 'enable_real_time_processing', True
+                ),
             },
         },
         status_code=200,
         message="Processing statistics retrieved successfully",
-    )
+    )

app/core/auth_external.py

@@ -16,34 +16,34 @@
 async def validate_token_with_external_service(token: str) -> Optional[Dict[str, Any]]:
     """
     Validate token with external auth service.
-    
+
     Args:
         token: JWT token to validate
-        
+
     Returns:
         User data if valid, None if invalid
     """
     settings = get_settings()
-    
+
     if not settings.auth_service_url:
         return None
-        
+
     try:
         async with httpx.AsyncClient(timeout=5) as client:
             response = await client.post(
                 f"{settings.auth_service_url}/validate-token",
                 json={"token": token},
                 headers={"Content-Type": "application/json"}
             )
-            
+
             if response.status_code == 200:
                 data = response.json()
                 logger.info("token_validated_with_external_service", user_id=data.get("user_id"))
                 return data
             else:
                 logger.warning("external_auth_validation_failed", status_code=response.status_code)
                 return None
-                
+
     except Exception as e:
         logger.error("external_auth_error", error=str(e))
         return None
@@ -52,15 +52,15 @@ async def validate_token_with_external_service(token: str) -> Optional[Dict[str,
 def validate_local_token(token: str) -> Optional[Dict[str, Any]]:
     """
     Validate JWT token locally.
-    
+
     Args:
         token: JWT token to validate
-        
+
     Returns:
         Token payload if valid, None if invalid
     """
     settings = get_settings()
-    
+
     try:
         payload = jwt.decode(
             token,
@@ -79,35 +79,35 @@ async def get_current_user(
 ) -> Dict[str, Any]:
     """
     Dependency to get current authenticated user.
-    
+
     This function:
     1. First tries to validate with external auth service (if URL configured)
     2. Falls back to local JWT validation
     3. Raises 401 if both fail
-    
+
     Args:
         credentials: HTTP authorization credentials
-        
+
     Returns:
         User information from token
-        
+
     Raises:
         HTTPException: If authentication fails
     """
     token = credentials.credentials
     settings = get_settings()
-    
+
     # Try external auth service first (if configured)
     if settings.auth_service_url:
         user_data = await validate_token_with_external_service(token)
         if user_data:
             return user_data
-    
+
     # Fallback to local validation
     user_data = validate_local_token(token)
     if user_data:
         return user_data
-    
+
     # If both fail, raise authentication error
     raise HTTPException(
         status_code=status.HTTP_401_UNAUTHORIZED,
@@ -121,19 +121,19 @@ async def get_current_user_optional(
 ) -> Optional[Dict[str, Any]]:
     """
     Optional authentication dependency.
-    
+
     Returns user data if authenticated, None if not.
     Useful for endpoints that work with or without authentication.
-    
+
     Args:
         credentials: Optional HTTP authorization credentials
-        
+
     Returns:
         User information if authenticated, None otherwise
     """
     if not credentials:
         return None
-        
+
     try:
         return await get_current_user(credentials)
     except HTTPException:
@@ -143,31 +143,31 @@ async def get_current_user_optional(
 def create_test_token(user_id: str = "test-user", roles: list = None) -> str:
     """
     Create a test JWT token for development/testing.
-    
+
     Args:
         user_id: User ID
         roles: List of user roles
-        
+
     Returns:
         JWT token string
     """
     from datetime import datetime, timedelta
-    
+
     settings = get_settings()
-    
+
     payload = {
         "sub": user_id,
         "user_id": user_id,
         "roles": roles or ["user"],
         "iat": datetime.utcnow(),
         "exp": datetime.utcnow() + timedelta(minutes=settings.jwt_expiration_minutes),
     }
-    
+
     token = jwt.encode(
         payload,
         settings.jwt_secret_key,
         algorithm=settings.jwt_algorithm
     )
-    
+
     logger.info("test_token_created", user_id=user_id)
     return token

app/core/config.py

@@ -75,7 +75,7 @@ class Settings(BaseSettings):
     api_gateway_public_key: Optional[str] = Field(
         default=None, description="API Gateway public key for JWT verification"
     )
-    
+
     # External Auth Service Configuration
     auth_service_url: Optional[str] = Field(
         default=None, description="External auth service URL for token validation"
@@ -103,7 +103,9 @@ class Settings(BaseSettings):
 
     # AI Configuration
     ai_analysis_enabled: bool = Field(
-        default=True, description="Enable AI-powered log analysis (if disabled, uses basic analysis)"
+        default=True, description=(
+            "Enable AI-powered log analysis (if disabled, uses basic analysis)"
+        )
     )
     ai_timeout_seconds: int = Field(
         default=10, ge=1, description="AI analysis timeout in seconds"