Merge pull request #5 from Ifechukwu001/fix/github-actions

Github Actions for Linting and  Static Typing

Author: Ifechukwu001

.github/workflows/lint-and-check.yml

@@ -0,0 +1,37 @@
+name: Linter & Type Checker
+on: [push, pull_request]
+jobs:
+  ruff:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Lint with Ruff
+        uses: astral-sh/ruff-action@v3
+        with:
+          version: 0.9.6
+
+      - name: Format with Ruff
+        uses: astral-sh/ruff-action@v3
+        with:
+          version: 0.9.6
+          args: "format --check --diff"
+
+  pyright:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup UV
+        uses: astral-sh/setup-uv@v5
+        with:
+          enable-cache: true
+
+      - name: Synchronize dependencies
+        run: uv sync
+
+      - name: Check with Pyright
+        uses: jakebailey/pyright-action@v2
+        with:
+          pylance-version: latest-release
+          project: pyproject.toml

README.md

@@ -4,6 +4,8 @@ Developers Foundry Wallet User Service System
 
  
 [![Version: v1.2.0](https://img.shields.io/badge/api-v1.2.0-blue?style=flat&logo=money)](CHANGELOG.md)
+[![Checked with pyright](https://microsoft.github.io/pyright/img/pyright_badge.svg)](https://microsoft.github.io/pyright/)
+[![Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json)](https://github.com/astral-sh/ruff)
 
 ---
 

pyproject.toml

@@ -35,6 +35,7 @@ version = { attr = "src.__version__" }
 
 [tool.ruff]
 fix = true
+extend-exclude = ["manage.py", "**/migrations/*.py"]
 
 [tool.ruff.lint]
 extend-select = [

src/api/middlewares/AppMiddleware.py

@@ -1,17 +1,13 @@
-from typing import Annotated
-
 import jwt
 from django.http import HttpRequest
 from ninja.security import HttpBearer
 
 from src.env import jwt_config
-from src.utils.svcs import Service
 from src.utils.logger import Logger
 
 
-@Service()
 class Authentication(HttpBearer):
-    def __init__(self, logger: Annotated[Logger, "Authentication"]) -> None:
+    def __init__(self, logger: Logger) -> None:
         super().__init__()
         self.logger = logger
 
@@ -35,3 +31,10 @@ def authenticate(self, request: HttpRequest, token: str) -> str:
         setattr(request, "auth_email", jwt_data["email"])
         setattr(request, "auth_id", jwt_data["user_id"])
         return token
+
+
+def get_authentication() -> Authentication:
+    return Authentication(Logger("Authentication"))
+
+
+authentication = get_authentication()

src/api/routes/__init__.py

@@ -2,8 +2,7 @@
 from django.http import HttpRequest
 
 from src.env import app
-from src.utils.svcs import Depends
-from src.api.middlewares.AppMiddleware import Authentication
+from src.api.middlewares.AppMiddleware import authentication
 
 api: NinjaAPI = NinjaAPI(
     version=app["version"],
@@ -15,12 +14,10 @@
 
 
 @api.get("/")
-def home(request: HttpRequest) -> dict:
+async def home(request: HttpRequest) -> dict:
     return {"message": "Hello, World!"}
 
 
-authentication = Depends(Authentication)
-
 api.add_router("/auth", "src.api.routes.Auth.router", tags=["Auth"])
 api.add_router(
     "/password/reset", "src.api.routes.PasswordReset.router", tags=["Password"]

src/utils/logger/Logger.py

@@ -1,6 +1,5 @@
-import inspect
 import logging
-from typing import TypedDict, get_type_hints
+from typing import TypedDict
 
 from src.env import app
 
@@ -14,14 +13,6 @@ class LogDataFormat(TypedDict):
 # @Service()
 class Logger:
     def __init__(self, context: str = "Root") -> None:
-        frame = inspect.currentframe()
-        if frame and (fb := frame.f_back) and (class_self := fb.f_locals.get("self")):
-            # Extract metadata from the constructor
-            init_params = get_type_hints(class_self.__class__.__init__)
-            metadata = init_params.get("logger", None)
-
-            if metadata and hasattr(metadata, "__metadata__"):
-                context = metadata.__metadata__[0]
         self.context = context
 
     def debug(

src/utils/svcs/__init__.py

@@ -1,9 +1,8 @@
 from .registry import init_registry, close_registry
-from .services import Depends, Service, ADepends
+from .services import Service, ADepends
 
 __all__ = [
     "ADepends",
-    "Depends",
     "Service",
     "close_registry",
     "init_registry",

src/utils/svcs/services.py

@@ -1,6 +1,5 @@
 from typing import TypeVar, Annotated, get_type_hints
 
-from asgiref.sync import async_to_sync
 from svcs.exceptions import ServiceNotFoundError
 
 from src.utils.logger import Logger
@@ -17,9 +16,6 @@ async def ADepends(cls: type[T]) -> T:
     return await container.aget(cls)
 
 
-Depends = async_to_sync(ADepends)
-
-
 async def get_logger(ann_context: str = "Root") -> Logger:
     ann = Annotated[Logger, ann_context]