Skip to content

Commit dca7fba

Browse files
DeveloperC286DeveloperC286
authored
feat!: from changed to singular positional argument (#80)
1 parent 17014d6 commit dca7fba

20 files changed

+126
-279
lines changed

‎end-to-end-tests/features/assert_current_version.feature‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,58 +3,58 @@ Feature: The current version argument supplied is asserted to be equal or greate
33

44
Scenario Outline: The current version assertion passes with batched together increments.
55
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
6-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
6+
When linting from the "<commit_hash>".
77
And the argument --from-version is provided as "<from_version>".
88
And the argument --current-version is provided as "<current_version>".
99
And the argument --calculation-mode is provided as "batch".
1010
Then the current version assertion passes.
1111

1212

1313
Examples:
14-
| repository | checkout_commit | from_commit_hash | from_version | current_version |
14+
| repository | checkout_commit | commit_hash | from_version | current_version |
1515
| https://github.com/yargs/yargs.git | 089417550ef5a5b8ce3578dd2a989191300b64cd | 262e796329f4a09083ca07e49f926ae43ac850e9 | 0.2.1 | 0.2.2 |
1616
| https://github.com/BlazeSoftware/atoms.git | c2dcb3e97a1bd3516bed85ff1769c30211f2337a | 46dd08718905cbdd2d056a2eac720052b9691985 | 11.0.0 | 12.0.1 |
1717
| https://github.com/gembaadvantage/uplift | ca8345039fbaceb667928d65741a43df3f72e1e6 | 30f8c01e28c70d53a25f7b20d93679d23ae0830b | 1.12.1 | 1.13.0 |
1818

1919

2020
Scenario Outline: The current version assertion fails with batched together increments.
2121
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
22-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
22+
When linting from the "<commit_hash>".
2323
And the argument --from-version is provided as "<from_version>".
2424
And the argument --current-version is provided as "<current_version>".
2525
And the argument --calculation-mode is provided as "batch".
2626
Then the current version assertion fails.
2727

2828

2929
Examples:
30-
| repository | checkout_commit | from_commit_hash | from_version | current_version |
30+
| repository | checkout_commit | commit_hash | from_version | current_version |
3131
| https://github.com/yargs/yargs.git | 089417550ef5a5b8ce3578dd2a989191300b64cd | 262e796329f4a09083ca07e49f926ae43ac850e9 | 0.2.1 | 0.2.1 |
3232
| https://github.com/BlazeSoftware/atoms.git | c2dcb3e97a1bd3516bed85ff1769c30211f2337a | 46dd08718905cbdd2d056a2eac720052b9691985 | 11.0.0 | 11.0.3 |
3333

3434

3535
Scenario Outline: The current version assertion passes with consecutive increments.
3636
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
37-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
37+
When linting from the "<commit_hash>".
3838
And the argument --from-version is provided as "<from_version>".
3939
And the argument --current-version is provided as "<current_version>".
4040
Then the current version assertion passes.
4141

4242

4343
Examples:
44-
| repository | checkout_commit | from_commit_hash | from_version | current_version |
44+
| repository | checkout_commit | commit_hash | from_version | current_version |
4545
| https://github.com/istanbuljs/istanbuljs.git | 1b52fe750d1f800c34dbff168614c0c73bd76026 | 5afe20347dd3ae954b31707a67f381f87920797f | 4.1.2 | 4.2.7 |
4646
| https://gitlab.com/dmfay/massive-js.git | 482c364acf5505b81c55245fac0472890d351662 | 3f20134864b19b11541287af440540c7ad0ed986 | 2.0.1 | 3.1.0 |
4747

4848

4949
Scenario Outline: The current version assertion fails with consecutive increments.
5050
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
51-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
51+
When linting from the "<commit_hash>".
5252
And the argument --from-version is provided as "<from_version>".
5353
And the argument --current-version is provided as "<current_version>".
5454
Then the current version assertion fails.
5555

5656

5757
Examples:
58-
| repository | checkout_commit | from_commit_hash | from_version | current_version |
58+
| repository | checkout_commit | commit_hash | from_version | current_version |
5959
| https://github.com/istanbuljs/istanbuljs.git | 1b52fe750d1f800c34dbff168614c0c73bd76026 | 5afe20347dd3ae954b31707a67f381f87920797f | 4.1.2 | 4.1.3 |
6060
| https://gitlab.com/dmfay/massive-js.git | 482c364acf5505b81c55245fac0472890d351662 | 3f20134864b19b11541287af440540c7ad0ed986 | 2.0.1 | 2.1.0 |

‎end-to-end-tests/features/batch_semantic_versioning.feature‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ Feature: The increments are batched together and the largest increment determine
33

44
Scenario Outline:
55
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
6-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
6+
When linting from the "<commit_hash>".
77
And the argument --from-version is provided as "<from_version>".
88
And the argument --calculation-mode is provided as "batch".
99
Then the returned version should be "<expected_version>".
1010

1111

1212
Examples:
13-
| repository | checkout_commit | from_commit_hash | from_version | expected_version |
13+
| repository | checkout_commit | commit_hash | from_version | expected_version |
1414
| https://github.com/yargs/yargs.git | 089417550ef5a5b8ce3578dd2a989191300b64cd | 262e796329f4a09083ca07e49f926ae43ac850e9 | 0.2.1 | 0.2.2 |
1515
| https://github.com/yargs/yargs.git | 027a6365b737e13116811a8ef43670196e1fa00a | 1f26de809432be9cc6f4f185629f6e5d13236598 | 0.2.3 | 0.3.0 |
1616
| https://github.com/yargs/yargs.git | 18b0b752424bf560271e670ff95a0f90c8386787 | ecfc2c474575c6cdbc6d273c94c13181bd1dbaa6 | 1.0.3 | 1.1.0 |

‎end-to-end-tests/features/consecutive_semantic_versioning.feature‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ Feature: The increments are applied consecutively to calculate the next semantic
33

44
Scenario Outline:
55
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
6-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
6+
When linting from the "<commit_hash>".
77
And the argument --from-version is provided as "<from_version>".
88
Then the returned version should be "<expected_version>".
99

1010

1111
Examples:
12-
| repository | checkout_commit | from_commit_hash | from_version | expected_version |
12+
| repository | checkout_commit | commit_hash | from_version | expected_version |
1313
| https://github.com/yargs/yargs.git | 089417550ef5a5b8ce3578dd2a989191300b64cd | 262e796329f4a09083ca07e49f926ae43ac850e9 | 0.2.1 | 0.2.2 |
1414
| https://github.com/yargs/yargs.git | 027a6365b737e13116811a8ef43670196e1fa00a | 1f26de809432be9cc6f4f185629f6e5d13236598 | 0.2.3 | 0.3.0 |
1515
| https://github.com/yargs/yargs.git | 18b0b752424bf560271e670ff95a0f90c8386787 | ecfc2c474575c6cdbc6d273c94c13181bd1dbaa6 | 1.0.3 | 1.1.1 |

‎end-to-end-tests/features/from_arguments_conflicts.feature‎

Lines changed: 0 additions & 79 deletions
This file was deleted.

‎end-to-end-tests/features/from_commit_hash.feature‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,41 +3,41 @@ Feature: A Git commit hash can be provided as an argument to indicate where to s
33

44
Scenario Outline:
55
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
6-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
6+
When linting from the "<commit_hash>".
77
And the argument --from-version is provided as "<from_version>".
88
And the argument --current-version is provided as "<current_version>".
99
Then the current version assertion passes.
1010

1111

1212
Examples:
13-
| repository | checkout_commit | from_commit_hash | from_version | current_version |
13+
| repository | checkout_commit | commit_hash | from_version | current_version |
1414
| https://github.com/istanbuljs/istanbuljs.git | 1b52fe750d1f800c34dbff168614c0c73bd76026 | 5afe20347dd3ae954b31707a67f381f87920797f | 4.1.2 | 4.2.7 |
1515
| https://gitlab.com/dmfay/massive-js.git | 482c364acf5505b81c55245fac0472890d351662 | 3f20134864b19b11541287af440540c7ad0ed986 | 2.0.1 | 3.1.0 |
1616

1717

1818
Scenario Outline:
1919
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
20-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
20+
When linting from the "<commit_hash>".
2121
And the argument --from-version is provided as "<from_version>".
2222
And the argument --current-version is provided as "<current_version>".
2323
Then the current version assertion fails.
2424

2525

2626
Examples:
27-
| repository | checkout_commit | from_commit_hash | from_version | current_version |
27+
| repository | checkout_commit | commit_hash | from_version | current_version |
2828
| https://github.com/istanbuljs/istanbuljs.git | 1b52fe750d1f800c34dbff168614c0c73bd76026 | 5afe20347dd3ae954b31707a67f381f87920797f | 4.1.2 | 4.1.3 |
2929
| https://gitlab.com/dmfay/massive-js.git | 482c364acf5505b81c55245fac0472890d351662 | 3f20134864b19b11541287af440540c7ad0ed986 | 2.0.1 | 2.1.0 |
3030

3131

3232
Scenario Outline: When you provide an invalid commit hash a relevant error message is returned.
3333
Given the repository "<repository>" is cloned and checked out at the commit "<checkout_commit>".
34-
When the argument --from-commit-hash is provided as "<from_commit_hash>".
34+
When linting from the "<commit_hash>".
3535
And the argument --from-version is provided as "<from_version>".
36-
Then their is a could not find commit hash "<from_commit_hash>" error.
36+
Then their is a could not find commit hash "<commit_hash>" error.
3737

3838

3939
Examples:
40-
| repository | checkout_commit | from_commit_hash | from_version |
40+
| repository | checkout_commit | commit_hash | from_version |
4141
| https://github.com/SergioBenitez/Rocket.git | 549c9241c41320fc5af76b53c2ffc3bd8db88f8c | ecfc2c474575c6cdbc6d273c94c13181bd1dbaa6 | 1.0.4 |
4242
| https://github.com/electron/electron.git | 8798571a77a4d2a7e073b046d2e8b56caa4d1e68 | a115eaa633856eb0b09f4019952f866e6b4ef96d | 0.2.12 |
4343
| https://gitlab.com/gitlab-org/release-cli.git | 451e0773944e47a4e2678c67691a69cf8934e76e | 1260e8a74de5c29c85ffd4e2b91632236ea55c3a | 3.2.0 |

0 commit comments

Comments
 (0)