Merge pull request #96 from DeveloperPaul123/feature/code-cleanup

bench: 3997113

Author: DeveloperPaul123

Cargo.lock

@@ -12,13 +12,13 @@ members = ["engine", "chess"]
 [dependencies]
 engine = { path = "engine" }
 chess = { path = "chess" }
-anyhow = "1.0.97"
-clap = { version = "4.5.32", features = ["derive"] }
+anyhow = "1.0.98"
+clap = { version = "4.5.37", features = ["derive"] }
 colored = "3.0.0"
 console = { version = "0.15.11", features = ["windows-console-colors"] }
 csv = "1.3.1"
 indicatif = { version = "0.17.11", features = ["rayon"] }
-rand = { version = "0.9.0", features = ["small_rng"] }
+rand = { version = "0.9.1", features = ["small_rng"] }
 rand_chacha = "0.9.0"
 rayon = "1.10.0"
 serde = { version = "1.0.219", features = ["derive"] }

Cargo.toml

@@ -8,7 +8,11 @@ make_dir := if os_family() == "windows" {
 }
 env_var_prefix := if os_family() == "windows" { "$env:" } else { "" }
 env_var_postfix := if os_family() == "windows" { ";" } else { "" }
-default: (build)
+default:
+    @just -l
+
+build-engine:
+    cargo rustc --release --bin byte-knight -- -C target-cpu=native
 
 [group('dev')]
 [doc('Build the project (default is debug)')]
@@ -64,9 +68,8 @@ lint:
 [group('chess')]
 [group('performance')]
 [doc('Run sarch benchmark - required before committing for OpenBench.')]
-search-bench:
+search-bench: build-engine
     echo "Running search benchmark..."
-    cargo rustc --release --bin byte-knight -- -C target-cpu=native
     ./target/release/byte-knight bench
 
 [group('chess')]

Justfile

@@ -4,6 +4,8 @@
 
 `byte-knight` is a UCI compliant chess engine written in Rust. It started as a port of the chess engine I submitted for Sebatian Lague's [Chess Engine Challenge](https://github.com/DeveloperPaul123/Leonidas) where it placed in the top 32 out of 600+ entries.
 
+You can challenge `byte-knight` yourself on [Lichess](https://lichess.org/@/byte-knight)!
+
 # Overview
 
 `byte-knight` is my first "real" Rust project. I'm a long time [C++ developer](https://github.com/DeveloperPaul123?tab=repositories&q=&type=source&language=c%2B%2B&sort=stargazers) and have been itching to learn Rust. I really enjoyed participating in the chess challenge a while back and thought that writing a new chess engine from scratch would be a good way to learn the language.
@@ -30,6 +32,7 @@ New features are tested via my [OpenBench](https://github.com/AndyGrant/OpenBenc
 - [Principle variation search](https://www.chessprogramming.org/Principal_Variation_Search)
 - [Aspiration windows](https://www.chessprogramming.org/Aspiration_Windows)
 - [Reverse futility pruning](https://www.chessprogramming.org/Reverse_Futility_Pruning)
+- [Late Move Reductions](https://www.chessprogramming.org/Late_Move_Reductions)
 - [Time control](https://www.chessprogramming.org/Time_Management)
   - Basic hard/soft limits
 - Move ordering

README.md

@@ -4,7 +4,7 @@
  * Created Date: Wednesday, August 21st 2024
  * Author: Paul Tsouchlos (DeveloperPaul123) ([email protected])
  * -----
- * Last Modified: Mon Apr 14 2025
+ * Last Modified: Thu Apr 24 2025
  * -----
  * Copyright (c) 2024 Paul Tsouchlos (DeveloperPaul123)
  * GNU General Public License v3.0 or later
@@ -117,7 +117,6 @@ impl Board {
         match side {
             Side::White => self.initialize_white_bbs(),
             Side::Black => self.initialize_black_bbs(),
-            _ => panic!("Invalid side"),
         }
     }
 
@@ -325,7 +324,6 @@ impl Board {
 
     /// Returns the bitboard for a specific piece and side.
     pub fn piece_bitboard(&self, piece: Piece, side: Side) -> &Bitboard {
-        debug_assert!(side != Side::Both);
         &self.piece_bitboards[side as usize][piece as usize]
     }
 
@@ -418,7 +416,6 @@ impl Board {
         match side {
             Side::White => castling_rights & CastlingAvailability::WHITE_KINGSIDE != 0,
             Side::Black => castling_rights & CastlingAvailability::BLACK_KINGSIDE != 0,
-            Side::Both => panic!("Cannot check if both sides can castle kingside"),
         }
     }
 
@@ -436,7 +433,6 @@ impl Board {
         match side {
             Side::White => castling_rights & CastlingAvailability::WHITE_QUEENSIDE != 0,
             Side::Black => castling_rights & CastlingAvailability::BLACK_QUEENSIDE != 0,
-            Side::Both => panic!("Cannot check if both sides can castle queenside"),
         }
     }
 

chess/src/board.rs

@@ -4,7 +4,7 @@
  * Created Date: Tuesday, November 26th 2024
  * Author: Paul Tsouchlos (DeveloperPaul123) ([email protected])
  * -----
- * Last Modified: Wed Mar 19 2025
+ * Last Modified: Thu Apr 24 2025
  * -----
  * Copyright (c) 2024 Paul Tsouchlos (DeveloperPaul123)
  * GNU General Public License v3.0 or later
@@ -270,7 +270,6 @@ pub(crate) fn active_color_to_fen(board: &Board) -> String {
     match board.side_to_move() {
         Side::White => "w".to_string(),
         Side::Black => "b".to_string(),
-        _ => panic!("Invalid side"),
     }
 }
 

chess/src/fen.rs

@@ -4,7 +4,7 @@
  * Created Date: Tuesday, November 26th 2024
  * Author: Paul Tsouchlos (DeveloperPaul123) ([email protected])
  * -----
- * Last Modified: Tue Nov 26 2024
+ * Last Modified: Thu Apr 24 2025
  * -----
  * Copyright (c) 2024 Paul Tsouchlos (DeveloperPaul123)
  * GNU General Public License v3.0 or later
@@ -180,7 +180,6 @@ impl MoveGenerator {
                     capture_mask |= en_passant_bb;
                 }
             }
-            Side::Both => panic!("Both side not allowed"),
         }
 
         (
@@ -268,7 +267,6 @@ impl MoveGenerator {
                 let captured_sq = match board.side_to_move() {
                     Side::White => sq - SOUTH as u8,
                     Side::Black => sq + NORTH as u8,
-                    Side::Both => panic!("Both side not allowed"),
                 };
                 occupancy &= !(Bitboard::from_square(captured_sq));
                 // get the squares attacked by the sliding pieces
@@ -337,7 +335,6 @@ impl MoveGenerator {
         let direction = match us {
             Side::White => NORTH as u8,
             Side::Black => SOUTH as u8,
-            Side::Both => panic!("Both side not allowed"),
         };
         let from_square = square.to_square_index();
         let to_square = match us {
@@ -355,7 +352,6 @@ impl MoveGenerator {
                     false => Some(result),
                 }
             }
-            Side::Both => panic!("Both side not allowed"),
         };
 
         let mut pushes: Bitboard = match to_square {
@@ -369,7 +365,6 @@ impl MoveGenerator {
         let can_double_push = match us {
             Side::White => square::is_square_on_rank(from_square, Rank::R2 as u8),
             Side::Black => square::is_square_on_rank(from_square, Rank::R7 as u8),
-            Side::Both => panic!("Both side not allowed"),
         };
 
         // if single push is obstructed, we can't double push
@@ -389,7 +384,6 @@ impl MoveGenerator {
                         false => Some(result),
                     }
                 }
-                Side::Both => panic!("Both side not allowed"),
             };
 
             if let Some(to) = double_push_sq {
@@ -559,7 +553,6 @@ impl MoveGenerator {
         let king_sq = match us {
             Side::White => Squares::E1,
             Side::Black => Squares::E8,
-            Side::Both => panic!("Both side not allowed"),
         };
 
         // sanity check
@@ -572,7 +565,6 @@ impl MoveGenerator {
             let king_side_rook = match us {
                 Side::White => Squares::H1,
                 Side::Black => Squares::H8,
-                Side::Both => panic!("Both side not allowed"),
             };
             // sanity check for the rook placement
             let maybe_rook = board.piece_on_square(king_side_rook);
@@ -588,13 +580,11 @@ impl MoveGenerator {
                 Side::Black => {
                     Bitboard::from_square(Squares::F8) | Bitboard::from_square(Squares::G8)
                 }
-                Side::Both => panic!("Both side not allowed"),
             };
 
             let king_side_target_sq = match us {
                 Side::White => Squares::G1,
                 Side::Black => Squares::G8,
-                Side::Both => panic!("Both side not allowed"),
             };
 
             let is_king_ray_empty = king_side_empty & occupancy == Bitboard::default();
@@ -608,7 +598,6 @@ impl MoveGenerator {
             let queen_side_rook = match us {
                 Side::White => Squares::A1,
                 Side::Black => Squares::A8,
-                Side::Both => panic!("Both side not allowed"),
             };
             // sanity check for the rook placement
             let maybe_rook = board.piece_on_square(queen_side_rook);
@@ -624,18 +613,15 @@ impl MoveGenerator {
                 Side::Black => {
                     Bitboard::from_square(Squares::C8) | Bitboard::from_square(Squares::D8)
                 }
-                Side::Both => panic!("Both side not allowed"),
             };
             let queen_side_empty = match us {
                 Side::White => queen_side_no_attack | Bitboard::from_square(Squares::B1),
                 Side::Black => queen_side_no_attack | Bitboard::from_square(Squares::B8),
-                Side::Both => panic!("Both side not allowed"),
             };
 
             let queen_side_target_sq = match us {
                 Side::White => Squares::C1,
                 Side::Black => Squares::C8,
-                Side::Both => panic!("Both side not allowed"),
             };
 
             let is_king_ray_empty = queen_side_empty & occupancy == Bitboard::default();

chess/src/legal_move_generation.rs

@@ -4,14 +4,18 @@
  * Created Date: Friday, August 16th 2024
  * Author: Paul Tsouchlos (DeveloperPaul123) ([email protected])
  * -----
- * Last Modified: Wed Apr 23 2025
+ * Last Modified: Thu Apr 24 2025
  * -----
  * Copyright (c) 2024 Paul Tsouchlos (DeveloperPaul123)
  * GNU General Public License v3.0 or later
  * https://www.gnu.org/licenses/gpl-3.0-standalone.html
  *
  */
 
+#![deny(clippy::unused_result_ok)]
+#![deny(clippy::panic)]
+#![deny(clippy::expect_used)]
+
 pub mod bitboard;
 pub mod bitboard_helpers;
 pub mod board;
@@ -27,9 +31,12 @@ pub mod move_history;
 pub mod move_list;
 pub mod move_making;
 pub mod moves;
+pub mod non_slider_piece;
 pub mod perft;
+pub mod piece_category;
 pub mod pieces;
 pub mod rank;
 pub mod side;
+pub mod slider_pieces;
 pub mod square;
 pub mod zobrist;