Suppressed deprecated code, Added more network capabilities, color correction, code clean-up.

Author: RajashekarRaju

app/src/main/java/com/developerbreach/developerbreach/fcm/AppFirebaseService.kt

@@ -1,5 +1,6 @@
 package com.developerbreach.developerbreach.fcm
 
+import android.annotation.SuppressLint
 import android.app.NotificationChannel
 import android.app.NotificationManager
 import android.app.PendingIntent
@@ -30,6 +31,7 @@ class AppFirebaseService : FirebaseMessagingService() {
      *
      * @param body FCM message body received.
      */
+    @SuppressLint("UnspecifiedImmutableFlag")
     private fun sendNotification(title: String, body: String) {
 
         val intent = Intent(this, MainActivity::class.java)

app/src/main/java/com/developerbreach/developerbreach/model/DataObjectConverters.kt

@@ -19,7 +19,8 @@ class ArticleDetailViewModel(
     val articleId: Int
 ) : AndroidViewModel(application) {
 
-    private val repository = AppRepository(getDatabaseInstance(application))
+    private val articleDatabase = getDatabaseInstance(application)
+    private val repository = AppRepository(articleDatabase)
 
     private val _authorData = MutableLiveData<Pair<String, String>>()
     val authorData: LiveData<Pair<String, String>>

app/src/main/java/com/developerbreach/developerbreach/view/detail/ArticleDetailViewModel.kt

@@ -1,17 +1,28 @@
 package com.developerbreach.developerbreach.view.network
 
+import android.content.Context
+import android.net.ConnectivityManager
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
 import androidx.navigation.fragment.findNavController
+import com.developerbreach.developerbreach.R
 import com.developerbreach.developerbreach.databinding.FragmentNetworkBinding
+import com.developerbreach.developerbreach.utils.showSnackBar
 
 
 class NetworkFragment : Fragment() {
 
     private lateinit var binding: FragmentNetworkBinding
+    private lateinit var manager: ConnectivityManager
+
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        val systemService = requireContext().getSystemService(Context.CONNECTIVITY_SERVICE)
+        manager = systemService as ConnectivityManager
+    }
 
     override fun onCreateView(
         inflater: LayoutInflater, container: ViewGroup?,
@@ -34,7 +45,12 @@ class NetworkFragment : Fragment() {
         })
 
         binding.noInternetConnectionTryAgain.setOnClickListener {
-            // checkNetworkConnection()
+            val isAvailable = NetworkManager(requireContext()).checkForActiveNetwork()
+            if (isAvailable) {
+                findNavController().navigateUp()
+            } else {
+                showSnackBar(getString(R.string.no_internet_connection), requireActivity())
+            }
         }
     }
 }

app/src/main/java/com/developerbreach/developerbreach/view/network/NetworkFragment.kt

@@ -3,6 +3,7 @@ package com.developerbreach.developerbreach.view.network
 import android.content.Context
 import android.net.ConnectivityManager
 import android.net.Network
+import android.net.NetworkCapabilities
 import androidx.core.content.ContextCompat
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
@@ -17,13 +18,14 @@ import androidx.lifecycle.MutableLiveData
  */
 class NetworkManager(context: Context) {
 
+    private val manager: ConnectivityManager? =
+        ContextCompat.getSystemService(context, ConnectivityManager::class.java)
+
     private val _isConnected = MutableLiveData<Boolean>()
     val isConnected: LiveData<Boolean>
         get() = _isConnected
 
     init {
-        val manager = ContextCompat.getSystemService(context, ConnectivityManager::class.java)
-
         manager?.registerDefaultNetworkCallback(object : ConnectivityManager.NetworkCallback() {
             override fun onAvailable(network: Network) {
                 _isConnected.postValue(true)
@@ -34,4 +36,11 @@ class NetworkManager(context: Context) {
             }
         })
     }
+
+    fun checkForActiveNetwork(): Boolean {
+        val activeNetwork: Network? = manager?.activeNetwork
+        val capabilities: NetworkCapabilities? = manager?.getNetworkCapabilities(activeNetwork)
+        return capabilities != null &&
+                capabilities.hasCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)
+    }
 }

app/src/main/java/com/developerbreach/developerbreach/view/network/NetworkManager.kt

@@ -89,7 +89,7 @@
                 app:layout_constraintTop_toBottomOf="@id/recent_posts_tag"
                 tools:itemCount="6"
                 tools:listitem="@layout/item_recent_articles"
-                tools:visibility="invisible" />
+                tools:visibility="visible" />
 
             <com.google.android.material.progressindicator.CircularProgressIndicator
                 android:id="@+id/progress_bar_recent_articles"

app/src/main/res/layout/fragment_home.xml

@@ -1,15 +1,14 @@
 <?xml version="1.0" encoding="utf-8"?>
-<com.google.android.material.card.MaterialCardView
-    xmlns:android="http://schemas.android.com/apk/res/android"
+<com.google.android.material.card.MaterialCardView xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="48dp"
     android:layout_marginHorizontal="16dp"
     android:layout_marginVertical="12dp"
+    app:cardBackgroundColor="?attr/colorSecondary"
     app:cardCornerRadius="8dp"
     app:cardElevation="0dp"
-    app:cardBackgroundColor="?attr/colorSecondary"
     app:layout_constraintStart_toStartOf="parent"
     app:layout_constraintTop_toTopOf="parent"
     tools:showIn="@layout/fragment_home">