Skip to content

Commit a50640c

Browse files
Merge pull request #15 from DevelopersBreach/yuga/detail-screen-scroll
Implement section-wise scroll behaviour on the Detail Screen
2 parents accb7ba + 4aade5d commit a50640c

File tree

23 files changed

+366
-416
lines changed

23 files changed

+366
-416
lines changed

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/DetailContentPreview.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/DetailScreenPreview.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,16 @@ import androidx.compose.runtime.Composable
44
import androidx.compose.ui.tooling.preview.PreviewLightDark
55
import com.developersbreach.kotlindictionarymultiplatform.previews.fakeTopicDetails
66
import com.developersbreach.kotlindictionarymultiplatform.ui.screens.detail.DetailScreenUI
7+
import com.developersbreach.kotlindictionarymultiplatform.ui.screens.detail.toDetailUi
78
import com.developersbreach.kotlindictionarymultiplatform.ui.theme.KotlinDictionaryTheme
89

910
@PreviewLightDark
1011
@Composable
1112
fun DetailScreenPreview() {
1213
KotlinDictionaryTheme {
13-
DetailScreenUI(topic = fakeTopicDetails())
14+
DetailScreenUI(
15+
detailUiState = fakeTopicDetails().toDetailUi(),
16+
navigateUp = {},
17+
)
1418
}
1519
}

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/DetailTopAppBarPreview.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/IntroductionSectionPreview.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/PitfallsSectionPreviews.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/RelatedTopicsSectionPreview.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/SectionsListPreview.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/SyntaxSectionPreview.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/detail/TableOfContentsPreview.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/navigation/AppNavigation.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ fun AppNavigation(
3434

3535
composable<AppDestinations.Detail> {
3636
val viewModel: DetailViewModel = koinViewModel()
37-
DetailScreen(viewModel = viewModel)
37+
DetailScreen(
38+
viewModel = viewModel,
39+
navigateUp = { navController.navigateUp() },
40+
)
3841
}
3942
}
4043
}

0 commit comments

Comments
 (0)