Skip to content

Commit ee2a149

Browse files
committed
- Replaced println with Logger for improved logging
- Deleted `TopicListScreen` and moved its functionality to `TopicScreen`
1 parent f50bb01 commit ee2a149

File tree

6 files changed

+13
-61
lines changed

6 files changed

+13
-61
lines changed

composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/core/KtorHttpClient.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.developersbreach.kotlindictionarymultiplatform.core
22

3+
import co.touchlab.kermit.Logger
34
import com.developersbreach.kotlindictionarymultiplatform.data.detail.ChatCompletionRequest
45
import com.developersbreach.kotlindictionarymultiplatform.data.detail.ChatCompletionResponse
56
import com.developersbreach.kotlindictionarymultiplatform.data.detail.ChatMessage
@@ -115,11 +116,11 @@ object KtorHttpClient {
115116
}
116117

117118
val text = response.bodyAsText()
118-
println("RAW RESPONSE:\n$text")
119+
Logger.i("RawResponse") { "RAW RESPONSE:\n$text" }
119120

120121
// Parse response
121122
val chatResp = json.decodeFromString(ChatCompletionResponse.serializer(), text)
122-
println(chatResp)
123+
Logger.i("ChatResponse") { "$chatResp" }
123124
val funcCall = chatResp.choices?.first()?.message?.functionCall ?: error("No function call in response")
124125

125126
// The arguments field is a JSON string: parse and decode into our DTO

composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/TopicListScreen.kt

Lines changed: 0 additions & 49 deletions
This file was deleted.

composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailScreen.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@ import androidx.compose.foundation.lazy.items
2020
@Composable
2121
fun DetailScreen(viewModel: DetailViewModel) {
2222
val topicState by viewModel.state.collectAsState()
23-
println("check topicState: $topicState")
2423

2524
topicState?.let { topic ->
26-
println("Topic data fetched: $topic")
2725
LazyColumn(modifier = Modifier.padding(16.dp)) {
2826
item {
2927
Text(text = topic.topicName, style = MaterialTheme.typography.h5)

composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailViewModel.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import androidx.lifecycle.SavedStateHandle
44
import androidx.lifecycle.ViewModel
55
import androidx.lifecycle.viewModelScope
66
import androidx.navigation.toRoute
7+
import co.touchlab.kermit.Logger
78
import com.developersbreach.kotlindictionarymultiplatform.data.detail.KotlinTopicDetails
89
import com.developersbreach.kotlindictionarymultiplatform.core.KtorHttpClient
910
import kotlinx.coroutines.flow.MutableStateFlow
@@ -29,11 +30,11 @@ class DetailViewModel(
2930
viewModelScope.launch {
3031
try {
3132
val topic = KtorHttpClient.generateTopicDetails(topicId, API_KEY)
32-
println("Fetched details: $topic")
33+
Logger.i("DetailViewModel") { "Fetched details: $topic" }
3334
_state.value = topic
34-
println("State updated with topic: $topic")
35+
Logger.i("DetailViewModel") { "State updated with topic: $topic" }
3536
} catch (e: Exception) {
36-
println("Error fetching topic: ${e.message}")
37+
Logger.e("DetailViewModel", e) { "Error fetching topic: ${e.message}" }
3738
}
3839
}
3940
}

composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicScreen.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import androidx.compose.runtime.collectAsState
1414
import androidx.compose.runtime.getValue
1515
import androidx.compose.ui.Modifier
1616
import androidx.compose.ui.unit.dp
17+
import co.touchlab.kermit.Logger
1718
import com.developersbreach.kotlindictionarymultiplatform.data.topic.model.Topic
1819

1920
@Composable
@@ -30,7 +31,7 @@ fun TopicScreen(
3031
) {
3132
items(topics) { topic ->
3233
TopicItem(topic = topic, onClick = {
33-
println("Topic clicked: ${topic.name}")
34+
Logger.i("TopicScreen") { "Topic clicked: ${topic.name}" }
3435
onTopicClick(topic.name)
3536
})
3637
}
@@ -42,7 +43,7 @@ fun TopicItem(
4243
topic: Topic,
4344
onClick: () -> Unit,
4445
) {
45-
println("Rendering topic item: ${topic.name}")
46+
Logger.i("TopicItem") { "Rendering topic item: ${topic.name}" }
4647

4748
Card(
4849
elevation = 4.dp,

composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicViewModel.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.developersbreach.kotlindictionarymultiplatform.ui.screens.topic
22

33
import androidx.lifecycle.ViewModel
44
import androidx.lifecycle.viewModelScope
5+
import co.touchlab.kermit.Logger
56
import com.developersbreach.kotlindictionarymultiplatform.data.topic.model.Topic
67
import com.developersbreach.kotlindictionarymultiplatform.data.topic.repository.TopicRepository
78
import kotlinx.coroutines.flow.MutableStateFlow
@@ -21,11 +22,10 @@ class TopicViewModel : ViewModel() {
2122
viewModelScope.launch {
2223
try {
2324
val topics = TopicRepository.getTopics()
24-
println("Successfully fetched topics: $topics")
25+
Logger.i("TopicFetch") { "Successfully fetched topics: $topics" }
2526
_topics.value = topics
2627
} catch (e: Exception) {
27-
println("Error fetching topics: ${e.message}")
28-
e.printStackTrace()
28+
Logger.e("TopicFetch", e) { "Error fetching topics: ${e.message}" }
2929
}
3030
}
3131
}

0 commit comments

Comments
 (0)