Implement section-wise scroll behaviour on the Detail Screen #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce and scrolling. - Dynamically build Table of Contents items based on available sections. - Enable smooth scrolling to sections when a Table of Contents item is clicked.
- Update `TableOfContents` to handle clicks and accept a list of items.
YugaJ7
requested review from
RajashekarRaju and
yesshreyes
and removed request for
RajashekarRaju and
yesshreyes
RajashekarRaju
requested changes
Jun 7, 2025
Member
RajashekarRaju
left a comment
RajashekarRaju
left a comment
There was a problem hiding this comment.
Please let me know if you don't know how to adapt your changes to suggested implementation. We will do it together.
This new implementation helps us isolate ViewModel/UI which allows us to write tests.
...droidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/PreviewUtils.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailContent.kt
Outdated
Show resolved
Hide resolved
...otlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailScreenUI.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@RajashekarRaju |
… with better mapping/configuration
…scroll # Conflicts: # composeApp/src/androidMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/previews/PreviewUtils.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailScreen.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailScreenUI.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailTopAppBar.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/components/IntroductionSection.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/components/PitfallsSection.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/components/RelatedTopicsSection.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/components/SectionsList.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/components/SyntaxSection.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/components/TableOfContents.kt
yesshreyes
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.