Implement paginated loading for TopicScreen
#24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajashekarRaju
requested changes
Jun 21, 2025
Member
RajashekarRaju
left a comment
RajashekarRaju
left a comment
There was a problem hiding this comment.
-
The current in-memory paging approach works for small datasets but isn’t scalable.
let’s switch to Paging 3 with a PagingSource and Pager so we only fetch 10 docs at a time. -
Update the Compose UI to use collectAsLazyPagingItems() and let the library handle load-more, placeholders, retry, and refresh for you.
-
For multiplatform, we support later, we’ll extract a common TopicPager interface in commonMain with expect/actual implementations Paging 3 on Android and a manual cursor-flow on desktop/iOS.
- Add Android Paging library and Firebase Firestore dependency. - Create `TopicPager` interface and platform-specific implementations. - Implement `AndroidPagingTopicPager` using `FirestoreTopicPagingSource`. - Introduce `Page` data class for paged results. - Update `TopicList` and `TopicScreen` to consume paged data. - Integrate Android Paging module into Koin.
- Implement `AndroidPagingTopicPager` using `PagingSource` for Android. - Introduce `Page`, `Topic`, and `TopicPager` for managing paged data. - Update `TopicViewModel` to consume data from `TopicPager`. - Remove manual pagination logic from `TopicViewModel`. - Move `TopicScreen` and `TopicList` to the `paging` package. - Add necessary dependencies for Paging and Firestore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.