Updated TopicScreen and Detail Screen with changed UI
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, search field, and a list of `TopicCard`s. - Refactored `DetailScreen` to use `Scaffold` with a top app bar. - Removed `compose.preview` and `compose.components.uiToolingPreview` dependencies and added `androidx.compose.ui:ui` dependency. - Added Noto Sans font files (bold, medium, regular).
…unctionality. - Add `ic_check` and `ic_content_copy` drawable resources. - Update `App.kt` to use `AppTypography`.
- Corrected trailing commas in `DetailScreen.kt` and `App.kt` for improved code style.
- Refactored `TopicScreen` for improved UI and state management. - Suppressed ktlint warnings in main platform files. - Disabled ktlint for generated files in `.editorconfig`.
# Conflicts: # composeApp/src/desktopMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/main.kt
Member
RajashekarRaju
left a comment
RajashekarRaju
left a comment
There was a problem hiding this comment.
Add extended material icons dependency instead of creating drawable resource files. You need below dependency
implementation(compose.materialIconsExtended)
...seApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/theme/Font.kt
Outdated
Show resolved
Hide resolved
...App/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/theme/Colors.kt
Outdated
Show resolved
Hide resolved
| Text(text = example.code, style = MaterialTheme.typography.body2) | ||
| Spacer(modifier = Modifier.height(8.dp)) | ||
| } | ||
| val tableOfContents = buildList { |
Member
There was a problem hiding this comment.
This sort of implementation is very confusing, UI behavior cannot be dynamic with this hardcoded behavior.
We will get back to this after you merge this PR with better implementation.
.../kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailScreen.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicScreen.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/composeResources/drawable/ic_bookmark.xml
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/composeResources/drawable/ic_bookmark_filled.xml
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/composeResources/drawable/ic_check.xml
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/composeResources/drawable/ic_content_copy.xml
Outdated
Show resolved
Hide resolved
- Add Material Icons Extended dependency. - Update `androidx.compose.ui:ui` to use version catalog.
- Refactored `Font.kt` and `Colors.kt` into the `ui.theme` package. - Introduced `KotlinDictionaryTheme` for applying Material 3 theming. - Updated `App.kt` to use `KotlinDictionaryTheme`. - Adjusted typography and color definitions for Material 3.
… and theme colors. - Replace custom bookmark and copy icons with Material icons. - Adjust padding and typography for consistency with Material3 guidelines.
…ources. - Replaced hardcoded strings with `stringResource` calls for UI elements.
# Conflicts: # composeApp/src/commonMain/composeResources/values/string.xml # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/detail/DetailScreen.kt # composeApp/src/commonMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicScreen.kt # gradle/libs.versions.toml
…ents. - Update color usage to `MaterialTheme.colorScheme`. - Remove unused `androidx.ui` dependency from `androidMain`.
…improved UI state management.
- Adjusted text colors in `TopicScreen` to use `onBackground` for better contrast.
… components. - Introduced a `PreviewUtils.kt` file containing utility functions for preview data.
…t/dark theme previews. - Change `CodeExampleBox` border color to `onPrimaryContainer`.
… `TopicViewModel`. - Updated `TopicScreen` and `SearchField` to use the ViewModel's state. - Modified `SearchFieldPreview` to reflect the changes in `SearchField`.
… logic. - Created `TopicScreenLayout` and `DetailScreenContent` composables.
- Introduce `FakeTopicViewModel` for `TopicScreenPreview`. - Add `fakeTopicDetails` and `sampleTopicList` to `PreviewUtils.kt` for sample data.
RajashekarRaju
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.