refactor: polishing

Author: TheAlexLichter

src/affine.js

@@ -16,6 +16,7 @@ const transform = (input, options) => {
   if (!LEGAL_MULT_KEYS.includes(options.keys[0])) {
     throw new Error('Illegal keys')
   }
+
   return [...input].map(c => rotateAndMultiply(c, getRotateAndMultiplyConfig(options))).join('')
 }
 

src/morse.js

@@ -9,9 +9,8 @@ export const decode = (input, options = {}) => {
     if (decodedCharacter) {
       return decodedCharacter[0]
     }
-    throwOrSilent(options, `Undecodable character ${character}`)
 
-    return options.omitUnknownCharacter ? '' : character
+    return throwOrSilent(options, `Undecodable character ${character}`) || options.omitUnknownCharacter ? '' : character
   }).join('')
 }
 
@@ -25,9 +24,7 @@ export const encode = (input, options = {}) => {
       return encodedCharacter[1]
     }
 
-    throwOrSilent(options, `Unencodable character ${character}`)
-
-    return options.omitUnknownCharacter ? '' : character
+    return throwOrSilent(options, `Unencodable character ${character}`) || options.omitUnknownCharacter ? '' : character
   }).join(options.separator)
 }
 

src/multiTap.js

@@ -7,11 +7,11 @@ export const encode = (input, options = {}) => {
       const decodedCharacter = Object.entries(alphabetWithSpaceKey(options.customMapping)).find(([, v]) => v.includes(c))
       if (decodedCharacter) {
         const amount = decodedCharacter[1].indexOf(c) + 1
-        return (options.exponentForm ? `${decodedCharacter[0]}^${amount}` : `${decodedCharacter[0]}`.repeat(amount))
+        return options.exponentForm ? `${decodedCharacter[0]}^${amount}` : `${decodedCharacter[0]}`.repeat(amount)
       }
       return throwOrSilent(options, `Unencodable character ${c}`)
     })
-    .filter(c => c.length)
+    .filter(Boolean)
     .join(options.withSpacing ? ' ' : '')
 }
 

src/multiplicative.js

@@ -7,8 +7,7 @@ const encode = (input, options = {}) => {
 }
 
 const decode = (input, options = {}) => {
-  options = { ...DEFAULT_OPTIONS, ...options }
-  options.decode = true
+  options = { ...DEFAULT_OPTIONS, ...options, decode: true }
 
   return transform(input, options)
 }

src/polybius.js

@@ -35,7 +35,7 @@ const encode = (input, options = {}) => {
     }
 
     return `${row}${col}`
-  }).filter(c => c.length).join(' ')
+  }).filter(Boolean).join(' ')
 }
 
 const decode = (input, options = {}) => {