refactor(graphics): inline rgb -> ycbcr

elmarco · elmarco · commit 5c65f1af03ba · 2024-11-05T12:19:32.000+04:00
That doesn't seem to help, rust is already inlining the function.

Signed-off-by: Marc-André Lureau &lt;marcandre.lureau@redhat.com&gt;
diff --git a/crates/ironrdp-graphics/src/color_conversion.rs b/crates/ironrdp-graphics/src/color_conversion.rs
@@ -248,6 +248,7 @@ impl From<YCbCr> for Rgb {
 }
 
 impl From<Rgb> for YCbCr {
+    #[inline(always)]
     fn from(Rgb { r, g, b }: Rgb) -> Self {
         // We scale the factors by << 15 into 32-bit integers in order
         // to avoid slower floating point multiplications.  Since the

Original file line number	Diff line number	Diff line change
`@@ -248,6 +248,7 @@ impl From<YCbCr> for Rgb {`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`impl From<Rgb> for YCbCr {`
	`251`	`+ #[inline(always)]`
`251`	`252`	`fn from(Rgb { r, g, b }: Rgb) -> Self {`
`252`	`253`	`// We scale the factors by << 15 into 32-bit integers in order`
`253`	`254`	`// to avoid slower floating point multiplications. Since the`