fix(egfx): correct MapSurfaceToScaledWindowPdu size

lamco-office · lamco-office · commit 9b7cf2944bc8 · 2025-12-16T19:55:28.000+02:00
Remove erroneous reserved field from FIXED_PART_SIZE.
Per MS-RDPEGFX 2.2.2.23, this PDU has no reserved field
(unlike MapSurfaceToScaledOutputPdu).
diff --git a/crates/ironrdp-egfx/src/pdu/cmd.rs b/crates/ironrdp-egfx/src/pdu/cmd.rs
@@ -1969,7 +1969,7 @@ pub struct MapSurfaceToScaledWindowPdu {
 impl MapSurfaceToScaledWindowPdu {
     const NAME: &'static str = "MapSurfaceToScaledWindowPdu";
 
-    const FIXED_PART_SIZE: usize = 2 /* SurfaceId */ + 2 /* reserved */ + 8 /* surfaceId */ + 4 /* mappedWidth */ + 4 /* mappedHeight */ + 4 /* targetWidth */ + 4 /* targetHeight */;
+    const FIXED_PART_SIZE: usize = 2 /* SurfaceId */ + 8 /* WindowId */ + 4 /* MappedWidth */ + 4 /* MappedHeight */ + 4 /* TargetWidth */ + 4 /* TargetHeight */;
 }
 
 impl Encode for MapSurfaceToScaledWindowPdu {

Original file line number	Diff line number	Diff line change
`@@ -1969,7 +1969,7 @@ pub struct MapSurfaceToScaledWindowPdu {`
`1969`	`1969`	`impl MapSurfaceToScaledWindowPdu {`
`1970`	`1970`	`const NAME: &'static str = "MapSurfaceToScaledWindowPdu";`
`1971`	`1971`
`1972`		`- const FIXED_PART_SIZE: usize = 2 /* SurfaceId / + 2 / reserved / + 8 / surfaceId / + 4 / mappedWidth / + 4 / mappedHeight / + 4 / targetWidth / + 4 / targetHeight */;`
	`1972`	`+ const FIXED_PART_SIZE: usize = 2 /* SurfaceId / + 8 / WindowId / + 4 / MappedWidth / + 4 / MappedHeight / + 4 / TargetWidth / + 4 / TargetHeight */;`
`1973`	`1973`	`}`
`1974`	`1974`
`1975`	`1975`	`impl Encode for MapSurfaceToScaledWindowPdu {`