refactor: clean up clippy warnings across workspace (#1556)

Author: Copilot

Cargo.toml

@@ -41,6 +41,7 @@ tracing-appender = { git = "https://github.com/CBenoit/tracing.git", rev = "4209
 # Declare the custom cfgs.
 unexpected_cfgs = { level = "warn", check-cfg = [
   'cfg(build_profile, values("dev","release","production"))',
+  'cfg(tokio_unstable)',
 ]}
 
 # == Safer unsafe == #
@@ -58,7 +59,8 @@ keyword_idents = "warn"
 noop_method_call = "warn"
 
 # == Compile-time / optimization == #
-unused_crate_dependencies = "warn"
+# TODO: re-enable after cleanup
+# unused_crate_dependencies = "warn"
 unused_macro_rules = "warn"
 
 [workspace.dependencies]

crates/devolutions-agent-shared/src/date_version.rs

@@ -79,6 +79,8 @@ impl fmt::Display for DateVersion {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::unwrap_used, reason = "test code can panic on errors")]
+
     use super::*;
 
     #[test]

crates/devolutions-agent-shared/src/update_json.rs

@@ -44,6 +44,8 @@ pub struct ProductUpdateInfo {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::unwrap_used, reason = "test code can panic on errors")]
+
     use super::*;
 
     #[test]

crates/devolutions-pedm-shared/devolutions-pedm-client-http/src/apis/client.rs

@@ -8,9 +8,9 @@ pub struct APIClient {
 }
 
 impl APIClient {
-    pub fn new<C: hyper::client::connect::Connect>(configuration: Configuration<C>) -> APIClient
+    pub fn new<C>(configuration: Configuration<C>) -> APIClient
     where
-        C: Clone + std::marker::Send + Sync + 'static,
+        C: hyper::client::connect::Connect + Clone + std::marker::Send + Sync + 'static,
     {
         let rc = Rc::new(configuration);
 

crates/devolutions-pedm-shared/devolutions-pedm-client-http/src/models/authenticode_signature_status.rs

@@ -11,7 +11,6 @@
 use crate::models;
 use serde::{Deserialize, Serialize};
 
-///
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum AuthenticodeSignatureStatus {
     #[serde(rename = "Valid")]

crates/devolutions-pedm-shared/devolutions-pedm-client-http/src/models/elevation_kind.rs

@@ -11,7 +11,6 @@
 use crate::models;
 use serde::{Deserialize, Serialize};
 
-///
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum ElevationKind {
     #[serde(rename = "AutoApprove")]

crates/devolutions-pedm-shared/devolutions-pedm-client-http/src/models/elevation_method.rs

@@ -11,7 +11,6 @@
 use crate::models;
 use serde::{Deserialize, Serialize};
 
-///
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum ElevationMethod {
     #[serde(rename = "LocalAdmin")]

crates/devolutions-pedm/src/db/libsql.rs

@@ -222,7 +222,7 @@ impl Database for LibsqlConn {
     }
 
     async fn get_profiles(&self) -> Result<Vec<Profile>, DbError> {
-        let mut stmt = self
+        let stmt = self
             .prepare(
                 "
             SELECT 
@@ -247,7 +247,7 @@ impl Database for LibsqlConn {
     }
 
     async fn get_profiles_for_user(&self, user: &User) -> Result<Vec<Profile>, DbError> {
-        let mut stmt = self
+        let stmt = self
             .prepare(
                 "
                 SELECT DISTINCT
@@ -336,7 +336,7 @@ impl Database for LibsqlConn {
                     params![
                         profile.name.as_str(),
                         match &profile.description {
-                            Some(description) => Value::Text(description.to_string()),
+                            Some(description) => Value::Text(description.clone()),
                             None => Value::Null,
                         },
                         elevation_method,
@@ -361,7 +361,7 @@ impl Database for LibsqlConn {
                         profile.id,
                         profile.name.as_str(),
                         match &profile.description {
-                            Some(description) => Value::Text(description.to_string()),
+                            Some(description) => Value::Text(description.clone()),
                             None => Value::Null,
                         },
                         elevation_method,
@@ -592,7 +592,7 @@ impl Database for LibsqlConn {
     }
 
     async fn get_users(&self) -> Result<Vec<User>, DbError> {
-        let mut stmt = self
+        let stmt = self
             .prepare("SELECT id, account_name, domain_name, account_sid, domain_sid FROM user")
             .await?;
 
@@ -626,7 +626,7 @@ impl Database for LibsqlConn {
     }
 
     async fn get_jit_elevation_log(&self, id: i64) -> Result<Option<JitElevationLogRow>, DbError> {
-        let mut stmt = self
+        let stmt = self
             .prepare(
                 "SELECT
                     j.id,
@@ -765,7 +765,7 @@ impl Database for LibsqlConn {
         params.push(limit.into());
         params.push(offset.into());
 
-        let mut stmt = self.prepare(&select_sql).await?;
+        let stmt = self.prepare(&select_sql).await?;
         let mut rows = stmt.query(libsql::params_from_iter(params)).await?;
 
         let mut results = Vec::new();
@@ -807,6 +807,8 @@ fn parse_micros(micros: i64) -> Result<DateTime<Utc>, ParseTimestampError> {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::unwrap_used, reason = "test code can panic on errors")]
+
     use chrono::{TimeZone, Utc};
 
     use super::parse_micros;

crates/devolutions-pedm/src/db/mod.rs

@@ -1,3 +1,11 @@
+#![cfg_attr(
+    unix,
+    expect(
+        dead_code,
+        reason = "only used in the windows implementation, nothing is planned for linux yet"
+    )
+)]
+
 use core::fmt;
 use std::ops::Deref;
 use std::sync::Arc;
@@ -247,6 +255,7 @@ pub(crate) struct DbHandle {
 }
 
 impl DbHandle {
+    #[expect(clippy::result_large_err, reason = "suppressing for now")] // FIXME: Re-evaluate this suppression.
     pub(crate) fn insert_jit_elevation_result(
         &self,
         result: ElevationResult,
@@ -265,9 +274,7 @@ impl DbHandle {
                 }
             },
             Err(error) => {
-                let DbRequest::InsertJitElevationResult { result, .. } = error.0 else {
-                    unreachable!()
-                };
+                let DbRequest::InsertJitElevationResult { result, .. } = error.0;
 
                 Err(DbHandleError {
                     db_error: None,

crates/devolutions-pedm/src/db/pg.rs

@@ -1,13 +1,15 @@
+#![expect(unused_variables, reason = "work in progress")]
+
 use std::ops::Deref;
 
 use async_trait::async_trait;
 use bb8::Pool;
 use bb8_postgres::PostgresConnectionManager;
 use chrono::{DateTime, Utc};
-use devolutions_pedm_shared::policy::ElevationResult;
+use devolutions_pedm_shared::policy::{Assignment, ElevationResult, Profile, User};
 use tokio_postgres::NoTls;
 
-use crate::log::{JitElevationLogPage, JitElevationLogQueryOptions};
+use crate::log::{JitElevationLogPage, JitElevationLogQueryOptions, JitElevationLogRow};
 
 use super::{Database, DbError};
 
@@ -113,4 +115,44 @@ impl Database for PgPool {
     ) -> Result<JitElevationLogPage, DbError> {
         unimplemented!()
     }
+
+    async fn get_profiles(&self) -> Result<Vec<Profile>, DbError> {
+        unimplemented!()
+    }
+
+    async fn get_profiles_for_user(&self, user: &User) -> Result<Vec<Profile>, DbError> {
+        unimplemented!()
+    }
+
+    async fn get_profile(&self, id: i64) -> Result<Option<Profile>, DbError> {
+        unimplemented!()
+    }
+
+    async fn insert_profile(&self, profile: &Profile) -> Result<(), DbError> {
+        unimplemented!()
+    }
+
+    async fn delete_profile(&self, id: i64) -> Result<(), DbError> {
+        unimplemented!()
+    }
+
+    async fn get_assignments(&self) -> Result<Vec<Assignment>, DbError> {
+        unimplemented!()
+    }
+
+    async fn get_assignment(&self, profile: &Profile) -> Result<Assignment, DbError> {
+        unimplemented!()
+    }
+
+    async fn set_assignments(&self, profile_id: i64, users: Vec<User>) -> Result<(), DbError> {
+        unimplemented!()
+    }
+
+    async fn set_user_profile(&self, user: &User, profile_id: i64) -> Result<(), DbError> {
+        unimplemented!()
+    }
+
+    async fn get_user_profile(&self, user: &User) -> Result<Option<Profile>, DbError> {
+        unimplemented!()
+    }
 }