Skip to content

fix(dgw): enable SSL protocol in RDP proxy #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2025
Merged

fix(dgw): enable SSL protocol in RDP proxy #1576

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59b9895
fix(devolutions-gateway): ConnectionRequest PDU protocol field: set P…
TheBestTvarynka Nov 14, 2025
0b1b074
feat(devolutions-gateway): clarify protocol flags;
TheBestTvarynka Dec 1, 2025
2b6e908
feat(devolutions-gateway): rdp proxy: forward client protocol flags;
TheBestTvarynka Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions devolutions-gateway/src/rdp_proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@ where
// > Credential Security Support Provider protocol (CredSSP) (section 5.4.5.2).
// > If this flag is set, then the PROTOCOL_SSL (0x00000001) flag SHOULD also be set
// > because Transport Layer Security (TLS) is a subset of CredSSP.
// However, crucially, it’s not strictly required (not "MUST").
// In fact, we purposefully choose to not set `PROTOCOL_SSL` unless `enable_winlogon` is `true`.
// This tells the server that we are not going to accept downgrading NLA to TLS security.
protocol: nego::SecurityProtocol::HYBRID | nego::SecurityProtocol::HYBRID_EX,
// Crucially, it’s not strictly required (not "MUST"). However, in practice, we cannot set PROTOCOL_HYBRID without PROTOCOL_SSL.
// Otherwise, the `mstsc.exe` will fail right after the CredSSP phase with the "An authentication error has occurred (0x609)" error.
// A similar case: https://serverfault.com/a/720161.
protocol: nego::SecurityProtocol::SSL | nego::SecurityProtocol::HYBRID | nego::SecurityProtocol::HYBRID_EX,
};
trace!(?connection_request_to_send, "Send Connection Request PDU to server");
send_pdu(server_framed, &x224::X224(connection_request_to_send))
Expand Down