fix: resolve clippy warnings in ironposh-psrp and ironposh-winrm

Author: irvingoujAtDevolution

crates/ironposh-psrp/examples/analyze.rs

@@ -316,7 +316,7 @@ pub fn main() -> Result<(), Box<dyn std::error::Error>> {
     // Check for --multi flag for defragmentation
     if args.len() > 2 && args[1] == "--multi" {
         print_separator("MULTI-FRAGMENT DEFRAGMENTATION MODE");
-        let fragments: Vec<&str> = args[2..].iter().map(|s| s.as_str()).collect();
+        let fragments: Vec<&str> = args[2..].iter().map(String::as_str).collect();
 
         match try_defragment_multiple_messages(&fragments) {
             Ok(messages) => {
@@ -464,7 +464,7 @@ pub fn main() -> Result<(), Box<dyn std::error::Error>> {
 
                         if !fragments.is_empty() {
                             let fragment_refs: Vec<&str> =
-                                fragments.iter().map(|s| s.as_str()).collect();
+                                fragments.iter().map(String::as_str).collect();
                             match try_defragment_multiple_messages(&fragment_refs) {
                                 Ok(messages) => {
                                     if messages.is_empty() {

crates/ironposh-psrp/src/fragmentation/tests.rs

@@ -1,13 +1,5 @@
-use super::*;
-use crate::messages::{
-    ApartmentState, ApplicationArguments, InitRunspacePool, PSThreadOptions, SessionCapability,
-};
-use tracing::info;
-use tracing_test::traced_test;
-use uuid::Uuid;
-
-#[cfg(test)]
-#[cfg(disabled_temporarily)] // Disabled due to from_crossterm compilation issues
+// Disabled due to from_crossterm compilation issues - uses `cfg(any())` which is always false
+#[cfg(any())]
 mod tests {
     use crate::messages::{HostDefaultData, HostInfo};
 

crates/ironposh-psrp/src/tests/command_xml_tests.rs

@@ -262,7 +262,7 @@ mod tests {
         // Convert back to ComplexObject
         let recreated_obj = ComplexObject::from(create_pipeline.clone());
 
-        let xml = PsValue::Object(recreated_obj.clone())
+        let xml = PsValue::Object(recreated_obj)
             .to_element_as_root()
             .unwrap()
             .to_xml_string()

crates/ironposh-psrp/src/tests/creation_xml.rs

@@ -1,18 +1,7 @@
-use crate::{
-    HostDefaultData, HostInfo,
-    fragmentation::{DefragmentResult, Defragmenter, Fragmenter},
-    messages::{
-        ApartmentState, ApplicationArguments, InitRunspacePool, PSThreadOptions, SessionCapability,
-    },
-};
-
-use tracing::info;
-use tracing_test::traced_test;
-use uuid::Uuid;
-
+// Disabled due to from_crossterm compilation issues - uses `cfg(any())` which is always false
+#[cfg(any())]
 #[test]
-#[cfg(disabled_temporarily)] // Disabled due to from_crossterm compilation issues
-#[traced_test]
+#[tracing_test::traced_test]
 fn test_combined_messages_like_runspace_open() {
     // Test the exact scenario from RunspacePool::open()
     let session_capability = SessionCapability {

crates/ironposh-psrp/src/tests/creation_xml_roundtrip.rs

@@ -144,7 +144,7 @@ fn test_creation_xml_roundtrip() {
                     if e.to_string().contains("Object reference") {
                         println!(
                             "   (This is expected for messages with object references - serialization needs reference preservation)"
-                        )
+                        );
                     } else {
                         println!("   (Unexpected error - investigate further)");
                     }

crates/ironposh-psrp/src/tests/error_record_test.rs

@@ -1,7 +1,7 @@
 #[cfg(test)]
 mod error_record_integration_tests {
     use crate::ps_value::{
-        ComplexObject, ComplexObjectContent, PsPrimitiveValue, PsProperty, PsType, PsValue,
+        ComplexObject, ComplexObjectContent, PsPrimitiveValue, PsProperty, PsValue,
     };
     use crate::{ErrorCategory, ErrorRecord};
     use std::collections::BTreeMap;
@@ -26,9 +26,8 @@ mod error_record_integration_tests {
             .expect("Should successfully deserialize XML to PsValue");
 
         // Extract the ComplexObject from PsValue
-        let complex_object = match ps_value {
-            PsValue::Object(obj) => obj,
-            _ => panic!("Expected PsValue::Object from XML parsing"),
+        let PsValue::Object(complex_object) = ps_value else {
+            panic!("Expected PsValue::Object from XML parsing")
         };
 
         println!("✅ Successfully parsed XML into ComplexObject");
@@ -86,7 +85,7 @@ mod error_record_integration_tests {
                 );
             }
             Err(e) => {
-                panic!("❌ Failed to parse ErrorRecord: {}", e);
+                panic!("❌ Failed to parse ErrorRecord: {e}");
             }
         }
     }
@@ -192,7 +191,7 @@ mod error_record_integration_tests {
             .serialize_extended_info(false)
             .error_category(Some(ErrorCategory::builder()
                 .category(13)
-                .activity(Some("".to_string()))
+                .activity(Some(String::new()))
                 .reason(Some("CommandNotFoundException".to_string()))
                 .target_name(Some("ed".to_string()))
                 .target_type(Some("String".to_string()))

crates/ironposh-psrp/src/tests/exact_xml_tests.rs

@@ -155,7 +155,7 @@ fn test_runspace_pool_message() {
     let mut host_data_dict = BTreeMap::new();
 
     // Add dictionary entries for host data
-    for (key, value_type, value_obj) in [
+    for (key, _value_type, value_obj) in [
         (
             9,
             "System.String",
@@ -839,13 +839,9 @@ fn test_deserialize_dictionary_xml() {
         assert_eq!(dict.len(), 2);
 
         // Verify we have the expected entries
-        let has_int_key = dict.keys().any(|k| {
-            if let PsValue::Primitive(PsPrimitiveValue::I32(9)) = k {
-                true
-            } else {
-                false
-            }
-        });
+        let has_int_key = dict
+            .keys()
+            .any(|k| matches!(k, PsValue::Primitive(PsPrimitiveValue::I32(9))));
         assert!(has_int_key, "Should have integer key 9");
 
         let has_string_key = dict.keys().any(|k| {

crates/ironposh-psrp/src/tests/parse_real_pipeline_output.rs

@@ -234,13 +234,13 @@ fn test_parse_real_pipeline_output_detailed_inspection() {
             match &obj.content {
                 ComplexObjectContent::Standard => println!("\nContent: Standard"),
                 ComplexObjectContent::ExtendedPrimitive(prim) => {
-                    println!("\nContent: ExtendedPrimitive({prim:?})")
+                    println!("\nContent: ExtendedPrimitive({prim:?})");
                 }
                 ComplexObjectContent::Container(container) => {
                     println!("\nContent: Container({container:?})");
                 }
                 ComplexObjectContent::PsEnums(enums) => {
-                    println!("\nContent: Enum({})", enums.value)
+                    println!("\nContent: Enum({})", enums.value);
                 }
             }
         }
@@ -259,8 +259,7 @@ fn classify_ps_value(value: &PsValue) -> String {
                 .type_def
                 .as_ref()
                 .and_then(|t| t.type_names.first())
-                .map(|s| s.as_ref())
-                .unwrap_or("Unknown");
+                .map_or("Unknown", AsRef::as_ref);
 
             let content_type = match &obj.content {
                 ComplexObjectContent::Standard => "Standard",

crates/ironposh-psrp/tests/test_psrp_message_edge_cases.rs

@@ -307,8 +307,7 @@ mod tests {
 
             assert!(
                 result.is_ok(),
-                "Message type {:?} should parse: {result:?}",
-                msg_type
+                "Message type {msg_type:?} should parse: {result:?}"
             );
 
             let msg = result.unwrap();

crates/ironposh-winrm/src/test_macro.rs

@@ -34,11 +34,11 @@ mod tests {
         // The TagValue implementation worked if we got here without panicking
 
         // Test deserialization with a simple XML string
-        let test_xml = r#"<test>
+        let test_xml = r"<test>
             <Action>test-action</Action>
             <MessageID>msg-123</MessageID>
             <To>destination</To>
-        </test>"#;
+        </test>";
 
         // Parse the XML back
         let doc = ironposh_xml::parser::parse(test_xml).expect("Failed to parse XML");