Skip to content

Commit 41d1c46

Browse files
authored
Merge pull request #127 from GwonsooLee/hotfix_rollingupdate
hotfix rolling update
2 parents 495beeb + 3f54068 commit 41d1c46

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

pkg/deployer/deployer.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,7 @@ func (d *Deployer) Polling(region schemas.RegionConfig, asg *autoscaling.Group,
107107
return false, fmt.Errorf("no autoscaling found for %s", d.AsgNames[region.Region])
108108
}
109109

110-
var threshold int64
111-
if !forceManifestCapacity && d.PrevInstanceCount[region.Region].Desired > d.Stack.Capacity.Desired && d.Mode != constants.CanaryDeployment {
112-
threshold = d.PrevInstanceCount[region.Region].Desired
113-
} else {
114-
threshold = d.AppliedCapacity.Desired
115-
}
110+
threshold := d.AppliedCapacity.Desired
116111

117112
if region.HealthcheckTargetGroup == "" && region.HealthcheckLB == "" {
118113
d.Logger.Info("health check skipped because of neither target group nor classic load balancer specified")

pkg/templates/templates.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ Configurations of stacks
3030
{{ decorate "underline bold" "Stack" }}: {{ $stack.Account }}
3131
{{ decorate "underline bold" "Account" }}: {{ $stack.Account }}
3232
{{ decorate "underline bold" "Replacement Type" }}: {{ $stack.ReplacementType }}
33+
{{ decorate "underline bold" "Rolling Update Instance Count" }}: {{ $stack.RollingUpdateInstanceCount }}
3334
{{ decorate "underline bold" "Environment" }}: {{ $stack.Env }}
3435
{{ decorate "underline bold" "IAM Instance Profile" }}: {{ $stack.IamInstanceProfile }}
3536
{{- if gt (len $stack.Tags) 0 }}

0 commit comments

Comments
 (0)