Merge pull request #124 from GwonsooLee/add_gp3

aed gp3 for ebs volume

Author: GwonsooLee

pkg/builder/builder.go

@@ -336,8 +336,8 @@ func (b Builder) CheckValidation() error {
 					return fmt.Errorf("not available volume type : %s", block.VolumeType)
 				}
 
-				if block.VolumeType == "gp2" && block.VolumeSize < 1 {
-					return errors.New("volume size of gp2 type should be larger than 1GiB")
+				if tool.IsStringInArray(block.VolumeType, []string{"gp2", "gp3"}) && block.VolumeSize < 1 {
+					return errors.New("volume size of gp2 or gp3 type should be larger than 1GiB")
 				}
 
 				if tool.IsStringInArray(block.VolumeType, constants.IopsRequiredBlockType) && block.VolumeSize < 4 {

pkg/builder/builder_test.go

@@ -345,7 +345,7 @@ func TestCheckValidationStack(t *testing.T) {
 
 	b.Stacks[0].BlockDevices[0].VolumeType = "gp2"
 	b.Stacks[0].BlockDevices[0].VolumeSize = 0
-	if err := b.CheckValidation(); err == nil || err.Error() != "volume size of gp2 type should be larger than 1GiB" {
+	if err := b.CheckValidation(); err == nil || err.Error() != "volume size of gp2 or gp3 type should be larger than 1GiB" {
 		t.Errorf("validation failed: volume size - gp2")
 	}
 

pkg/constants/constants.go

@@ -185,7 +185,7 @@ var (
 	AWSConfigPath = HomeDir() + "/.aws/config"
 
 	// AvailableBlockTypes is a list of available ebs block types
-	AvailableBlockTypes = []string{"io1", "io2", "gp2", "st1", "sc1"}
+	AvailableBlockTypes = []string{"io1", "io2", "gp2", "gp3", "st1", "sc1"}
 
 	// IopsRequiredBlockType is a list of ebs type which requires iops
 	IopsRequiredBlockType = []string{"io1", "io2"}

test/test_manifest.yaml

@@ -96,6 +96,17 @@ stacks:
     lifecycle_callbacks:
       pre_terminate_past_cluster:
         - service hello stop
+    # lifecycle hooks
+    lifecycle_hooks:
+      # Lifecycle hooks for launching new instances
+      launch_transition:
+        - lifecycle_hook_name: hello-launch-lifecycle-hook
+          heartbeat_timeout: 30
+          default_result: CONTINUE
+          notification_metadata: "this is test for launching"
+          #notification_target_arn: arn:aws:sns:ap-northeast-2:816736805842:test
+          #role_arn: arn:aws:iam::816736805842:role/test-autoscaling-role
+
     regions:
       - region: ap-northeast-2
         instance_type: t3.medium
@@ -278,6 +289,9 @@ stacks:
         volume_size: 8
         volume_type: "io2"
         iops: 100
+      - device_name: /dev/xvdb
+        volume_size: 400
+        volume_type: "gp3"
     autoscaling: *autoscaling_policy
     alarms: *autoscaling_alarms