Skip to content

Commit 50cf4e4

Browse files
authored
[spirv] Re-enable MeshShading tests (microsoft#5584)
The bug that required these tests to be disabled appears to have been fixed at some point. Re-enabling validation as they now pass. Closes microsoft#3006
1 parent f9219a9 commit 50cf4e4

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

tools/clang/unittests/SPIRV/CodeGenSpirvTest.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2774,9 +2774,7 @@ TEST_F(FileTest, MeshShadingEXTAmplification) {
27742774

27752775
// === MeshShading NV examples ===
27762776
TEST_F(FileTest, MeshShadingNVMeshTriangle) {
2777-
// TODO: Re-enable spirv-val once issue#3006 is fixed.
2778-
runFileTest("meshshading.nv.triangle.mesh.hlsl", Expect::Success,
2779-
/* runValidation */ false);
2777+
runFileTest("meshshading.nv.triangle.mesh.hlsl", Expect::Success);
27802778
}
27812779
TEST_F(FileTest, MeshShadingNVMeshLine) {
27822780
runFileTest("meshshading.nv.line.mesh.hlsl");
@@ -2785,9 +2783,7 @@ TEST_F(FileTest, MeshShadingNVMeshPoint) {
27852783
runFileTest("meshshading.nv.point.mesh.hlsl");
27862784
}
27872785
TEST_F(FileTest, MeshShadingNVMeshBuffer) {
2788-
// TODO: Re-enable spirv-val once issue#3006 is fixed.
2789-
runFileTest("meshshading.nv.buffer.mesh.hlsl", Expect::Success,
2790-
/* runValidation */ false);
2786+
runFileTest("meshshading.nv.buffer.mesh.hlsl", Expect::Success);
27912787
}
27922788
TEST_F(FileTest, MeshShadingNVMeshError1) {
27932789
runFileTest("meshshading.nv.error1.mesh.hlsl", Expect::Failure);

0 commit comments

Comments
 (0)