Removing dx.temp for lib target, since it's disallowed by the validator (microsoft#5832)

This change makes `DxilFinalizeModule` remove `dx.temp` metadata
regardless of target profile.

`DxilFinalizeModule` pass removes metadata that the validator disallows
in the final DXIL. These metadata are only removed for non-lib target,
however dx.temp is something that the validator does not allow even in
lib target. There is no reason to keep this metadata because it's only
used for inserting nops and that's not something we do when linking
libraries.

Author: adam-yang

lib/HLSL/DxilPreparePasses.cpp

@@ -800,28 +800,26 @@ class DxilFinalizeModule : public ModulePass {
       unsigned DxilMinor = 0;
       DM.GetDxilVersion(DxilMajor, DxilMinor);
 
-      bool IsLib = DM.GetShaderModel()->IsLib();
+      DenseSet<unsigned> IllegalMDSet;
+      unsigned DxilTempMDKind =
+          M.getContext().getMDKindID(DxilMDHelper::kDxilTempAllocaMDName);
+      IllegalMDSet.insert(DxilTempMDKind);
+
       // Skip validation patch for lib.
+      bool IsLib = DM.GetShaderModel()->IsLib();
       if (!IsLib) {
-        unsigned DxilTempMDKind =
-            M.getContext().getMDKindID(DxilMDHelper::kDxilTempAllocaMDName);
         if (DXIL::CompareVersions(ValMajor, ValMinor, 1, 1) <= 0) {
-          DenseSet<unsigned> IllegalMDSet;
           IllegalMDSet.insert(LLVMContext::MD_tbaa);
           IllegalMDSet.insert(LLVMContext::MD_prof);
           for (unsigned I = LLVMContext::MD_fpmath + 1;
                I <= LLVMContext::MD_dereferenceable_or_null; ++I) {
             IllegalMDSet.insert(I);
           }
-          IllegalMDSet.insert(DxilTempMDKind);
-          patchInstructionMetadata(M, IllegalMDSet);
-        } else {
-          DenseSet<unsigned> IllegalMDSet;
-          IllegalMDSet.insert(DxilTempMDKind);
-          patchInstructionMetadata(M, IllegalMDSet);
         }
       }
 
+      patchInstructionMetadata(M, IllegalMDSet);
+
       // Replace lifetime intrinsics if requested or necessary.
       const bool forceZeroStoreLifetimes = DM.GetForceZeroStoreLifetimes();
       if (forceZeroStoreLifetimes ||

tools/clang/test/HLSLFileCheckLit/passes/dxil/dxilfinalize/illegal_metadata_lib.ll

@@ -0,0 +1,50 @@
+; RUN: opt -hlsl-dxil-module-init -hlsl-dxilfinalize %s -S | FileCheck %s
+
+; Make sure !dx.temp is removed even for lib targets.
+
+; CHECK-LABEL:define void @main
+; CHECK-NOT:!dx.temp
+
+target datalayout = "e-m:e-p:32:32-i1:32-i8:32-i16:32-i32:32-i64:64-f16:32-f32:32-f64:64-n8:16:32:64"
+target triple = "dxil-ms-dx"
+
+; Function Attrs: nounwind
+define void @main(float* noalias nocapture readnone) #0 {
+entry:
+  call void @dx.op.storeOutput.f32(i32 5, i32 0, i32 0, i8 0, float 0.000000e+00), !dx.temp !9
+  ret void
+}
+
+; Function Attrs: nounwind
+declare void @dx.op.storeOutput.f32(i32, i32, i32, i8, float) #0
+
+attributes #0 = { nounwind }
+
+!llvm.module.flags = !{!0}
+!pauseresume = !{!1}
+!llvm.ident = !{!2}
+!dx.version = !{!3}
+!dx.valver = !{!4}
+!dx.shaderModel = !{!5}
+!dx.typeAnnotations = !{!6}
+!dx.entryPoints = !{!13, !14}
+
+!0 = !{i32 2, !"Debug Info Version", i32 3}
+!1 = !{!"hlsl-dxilemit", !"hlsl-dxilload"}
+!2 = !{!"dxc(private) 1.7.0.14005 (main, 96e13a0e0-dirty)"}
+!3 = !{i32 1, i32 3}
+!4 = !{i32 1, i32 7}
+!5 = !{!"lib", i32 6, i32 3}
+!6 = !{i32 1, void (float*)* @main, !7}
+!7 = !{!8, !10}
+!8 = !{i32 0, !9, !9}
+!9 = !{}
+!10 = !{i32 1, !11, !12}
+!11 = !{i32 4, !"SV_Target", i32 7, i32 9}
+!12 = !{i32 0}
+!13 = !{null, !"", null, null, null}
+!14 = !{void (float*)* @main, !"main", !15, null, !18}
+!15 = !{null, !16, null}
+!16 = !{!17}
+!17 = !{i32 0, !"SV_Target", i8 9, i8 16, !12, i8 0, i32 1, i8 1, i32 0, i8 0, null}
+!18 = !{i32 8, i32 0, i32 5, !12}