Skip to content

Commit 6f1c8e2

Browse files
authored
Disassembler: Remove duplicated "signature" in output (microsoft#6726)
There is an extra "signature" in the Patch Constant signature part of the disassembler output, causing the "Patch Constant signature signature" to appear. This PR removes the extra "signature" from the output. Example HLSL input: ```hlsl struct OutputConstantData { float tessFactor[4] : SV_TessFactor; float insideTessFactor[2] : SV_InsideTessFactor; }; OutputConstantData HSConstant() { OutputConstantData output; return output; } [domain("quad")] [partitioning("integer")] [outputtopology("triangle_cw")] [outputcontrolpoints(1)] [patchconstantfunc("HSConstant")] void HSMain() {} ``` Example Disassembler output: ```diff ... ; - ; Patch Constant signature signature: + ; Patch Constant signature: ; ; Name Index Mask Register SysValue Format Used ; -------------------- ----- ------ -------- -------- ------- ------ ; SV_TessFactor 0 w 0 QUADEDGE float w ; SV_TessFactor 1 w 1 QUADEDGE float w ; SV_TessFactor 2 w 2 QUADEDGE float w ; SV_TessFactor 3 w 3 QUADEDGE float w ; SV_InsideTessFactor 0 w 4 QUADINT float w ; SV_InsideTessFactor 1 w 5 QUADINT float w ; ... ```
1 parent 198e61b commit 6f1c8e2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/clang/tools/dxcompiler/dxcdisassembler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1681,7 +1681,7 @@ HRESULT Disassemble(IDxcBlob *pProgram, raw_string_ostream &Stream) {
16811681
DxilPartIsType(DFCC_PatchConstantSignature));
16821682
if (it != end(pContainer)) {
16831683
PrintSignature(
1684-
"Patch Constant signature",
1684+
"Patch Constant",
16851685
reinterpret_cast<const DxilProgramSignature *>(GetDxilPartData(*it)),
16861686
false, Stream, /*comment*/ ";");
16871687
}

0 commit comments

Comments
 (0)