Skip to content

Commit bc91bc5

Browse files
authored
Reserve some RDAT/DXIL enum values used by the mesh node preview (microsoft#6818)
Let's ensure we don't accidentally stomp on these. If we do choose to break them, it should be intentional, not accidental.
1 parent ef4f44d commit bc91bc5

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

include/dxc/DXIL/DxilConstants.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1604,6 +1604,7 @@ enum class NodeLaunchType {
16041604
Broadcasting,
16051605
Coalescing,
16061606
Thread,
1607+
Reserved_Mesh,
16071608

16081609
LastEntry
16091610
};

include/dxc/DxilContainer/DxilRuntimeReflection.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ enum class RuntimeDataPartType : uint32_t {
6868
NodeShaderInfoTable = 11,
6969
Last_1_8 = NodeShaderInfoTable,
7070

71+
Reserved_MeshNodesPreviewInfoTable = 12,
72+
7173
// Insert experimental here.
7274
SignatureElementTable,
7375
VSInfoTable,
@@ -113,6 +115,8 @@ enum class RecordTableIndex : unsigned {
113115
IONodeTable,
114116
NodeShaderInfoTable,
115117

118+
Reserved_MeshNodesPreviewInfoTable,
119+
116120
DxilPdbInfoTable,
117121
DxilPdbInfoSourceTable,
118122
DxilPdbInfoLibraryTable,

include/dxc/DxilContainer/RDAT_LibraryTypes.inl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,8 @@ RDAT_ENUM_START(NodeFuncAttribKind, uint32_t)
265265
RDAT_ENUM_VALUE(MaxRecursionDepth, 5)
266266
RDAT_ENUM_VALUE(LocalRootArgumentsTableIndex, 6)
267267
RDAT_ENUM_VALUE(MaxDispatchGrid, 7)
268+
RDAT_ENUM_VALUE(Reserved_MeshNodePreview1, 8)
269+
RDAT_ENUM_VALUE(Reserved_MeshNodePreview2, 9)
268270
RDAT_ENUM_VALUE_NODEF(LastValue)
269271
RDAT_ENUM_END()
270272

@@ -307,9 +309,10 @@ RDAT_DXIL_ENUM_START(hlsl::DXIL::NodeLaunchType, uint32_t)
307309
RDAT_ENUM_VALUE_NODEF(Broadcasting)
308310
RDAT_ENUM_VALUE_NODEF(Coalescing)
309311
RDAT_ENUM_VALUE_NODEF(Thread)
312+
RDAT_ENUM_VALUE_NODEF(Reserved_Mesh)
310313
RDAT_ENUM_VALUE_NODEF(LastEntry)
311314
#if DEF_RDAT_ENUMS == DEF_RDAT_DUMP_IMPL
312-
static_assert((unsigned)hlsl::DXIL::NodeLaunchType::LastEntry == 4,
315+
static_assert((unsigned)hlsl::DXIL::NodeLaunchType::LastEntry == 5,
313316
"otherwise, RDAT_DXIL_ENUM definition needs updating");
314317
#endif
315318
RDAT_ENUM_END()

0 commit comments

Comments
 (0)