Skip to content

Commit ee37b44

Browse files
committed
Don't pass accessors as tempoary objects
1 parent 686fcec commit ee37b44

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

CountingSort/app_resources/prefix_sum_shader.comp.hlsl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,11 @@ uint32_t3 nbl::hlsl::glsl::gl_WorkGroupSize()
4343
void main(uint32_t3 ID : SV_GroupThreadID, uint32_t3 GroupID : SV_GroupID)
4444
{
4545
nbl::hlsl::sort::counting <PtrAccessor, PtrAccessor, PtrAccessor> counter;
46+
PtrAccessor input_accessor = PtrAccessor::createAccessor(pushData.inputKeyAddress);
47+
PtrAccessor scratch_accessor = PtrAccessor::createAccessor(pushData.scratchAddress);
4648
counter.histogram(
47-
PtrAccessor::createAccessor(pushData.inputKeyAddress),
48-
PtrAccessor::createAccessor(pushData.scratchAddress),
49+
input_accessor,
50+
scratch_accessor,
4951
pushData
5052
);
5153
}

CountingSort/app_resources/scatter_shader.comp.hlsl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,13 @@ uint32_t3 nbl::hlsl::glsl::gl_WorkGroupSize()
6868
void main(uint32_t3 ID : SV_GroupThreadID, uint32_t3 GroupID : SV_GroupID)
6969
{
7070
nbl::hlsl::sort::counting <DoublePtrAccessor, DoublePtrAccessor, PtrAccessor> counter;
71+
DoublePtrAccessor key_accessor = DoublePtrAccessor::createAccessor(pushData.inputKeyAddress, pushData.outputKeyAddress);
72+
DoublePtrAccessor value_accessor = DoublePtrAccessor::createAccessor(pushData.inputValueAddress, pushData.outputValueAddress);
73+
PtrAccessor scratch_accessor = PtrAccessor::createAccessor(pushData.scratchAddress);
7174
counter.scatter(
72-
DoublePtrAccessor::createAccessor(pushData.inputKeyAddress, pushData.outputKeyAddress),
73-
DoublePtrAccessor::createAccessor(pushData.inputValueAddress, pushData.outputValueAddress),
74-
PtrAccessor::createAccessor(pushData.scratchAddress),
75+
key_accessor,
76+
value_accessor,
77+
scratch_accessor,
7578
pushData
7679
);
7780
}

0 commit comments

Comments
 (0)