slight variable and function rename

Author: devshgraphicsprogramming

examples_tests/42.FragmentShaderPathTracer/common.glsl

@@ -242,12 +242,14 @@ vec3 BSDFNode_getReflectance(in BSDFNode node, in float VdotH)
         return albedoOrRealIoR;
 }
 
-float BSDFNode_getMISWeight(in BSDFNode bsdf)
+float BSDFNode_getNEESkipProb(in BSDFNode bsdf)
 {
-    const float alpha = BSDFNode_getRoughness(bsdf);
-    const bool notDiffuse = BSDFNode_isNotDiffuse(bsdf);
-    const float DIFFUSE_MIS_NEE_PROB = 1.0;
-    return (notDiffuse ? (1.0-alpha*alpha):1.0)*DIFFUSE_MIS_NEE_PROB;
+    if (BSDFNode_isNotDiffuse(bsdf))
+    {
+        const float alpha = BSDFNode_getRoughness(bsdf);
+        return alpha*alpha;
+    }
+    return 0.0;
 }
 
 #include <nbl/builtin/glsl/colorspace/EOTF.glsl>

examples_tests/42.FragmentShaderPathTracer/litBySphere.frag

@@ -137,9 +137,9 @@ bool closestHitProgram(in uint depth, in uint _sample, inout Ray_t ray, inout nb
         const float monochromeEta = dot(throughputCIE_Y,BSDFNode_getEta(bsdf)[0])/(throughputCIE_Y.r+throughputCIE_Y.g+throughputCIE_Y.b);
 
         // do NEE
-        const float neeProbability = BSDFNode_getMISWeight(bsdf);
+        const float neeSkipProbability = BSDFNode_getNEESkipProb(bsdf);
         float rcpChoiceProb;
-        if (!nbl_glsl_partitionRandVariable(neeProbability,epsilon[0].z,rcpChoiceProb))
+        if (nbl_glsl_partitionRandVariable(neeSkipProbability,epsilon[0].z,rcpChoiceProb))
         {
             vec3 neeContrib; float lightPdf, t;
             nbl_glsl_LightSample _sample = nbl_glsl_light_generate_and_remainder_and_pdf(neeContrib,lightPdf,t,intersection,interaction,epsilon[0],depth);
@@ -175,7 +175,7 @@ bool closestHitProgram(in uint depth, in uint _sample, inout Ray_t ray, inout nb
         if (bsdfPdf>bsdfPdfThreshold && getLuma(throughput)>lumaThroughputThreshold)
         {
             ray._payload.throughput = throughput;
-            ray._payload.otherTechniqueHeuristic = neeProbability/bsdfPdf; // numerically stable, don't touch
+            ray._payload.otherTechniqueHeuristic = (1.0-neeSkipProbability)/bsdfPdf; // numerically stable, don't touch
             ray._payload.otherTechniqueHeuristic *= ray._payload.otherTechniqueHeuristic;
 
             // trace new ray