Skip to content

Commit 040e259

Browse files
committed
make sure Nabla compiles after merge, but 01 and 06 doesn't
1 parent 3041671 commit 040e259

File tree

5 files changed

+5
-24
lines changed

5 files changed

+5
-24
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/toolchains/android/build.cmake)
1515

1616
project(Nabla LANGUAGES CXX C)
1717

18-
option(NBL_STATIC_BUILD OFF) # ON for static builds, OFF for shared
19-
option(NBL_DYNAMIC_MSVC_RUNTIME ON)
18+
option(NBL_STATIC_BUILD "" OFF) # ON for static builds, OFF for shared
19+
option(NBL_DYNAMIC_MSVC_RUNTIME "" ON)
2020

2121
if(NBL_STATIC_BUILD)
2222
message(STATUS "Static Nabla build enabled!")

include/nbl/video/IDeviceMemoryAllocation.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ TO COPY BETWEEN MEMORY ALLOCATIONS you need to have them bound to
2020
one or two IGPUBuffers and execute IVideoDriver::copyBuffer between them.
2121
We only support persistently mapped buffers with ARB_buffer_storage.
2222
Please don't ask us to support Buffer Orphaning. */
23-
class NBL_API IDriverMemoryAllocation : public virtual core::IReferenceCounted
23+
class NBL_API IDeviceMemoryAllocation : public virtual core::IReferenceCounted
2424
{
2525
friend class ILogicalDevice;
2626

include/nbl/video/IGPUBuffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace nbl::video
2222
/** For additional OpenGL DSA state-free operations such as flushing mapped ranges or
2323
buffer to buffer copies, one needs a command buffer in Vulkan as these operations are
2424
performed by the GPU and not wholly by the driver, so look for them in IGPUCommandBuffer. */
25-
class NBL_API IGPUBuffer : public asset::IBuffer, public IDriverMemoryBacked, public IBackendObject
25+
class NBL_API IGPUBuffer : public asset::IBuffer, public IDeviceMemoryBacked, public IBackendObject
2626
{
2727
public:
2828
struct SCachedCreationParams

include/nbl/video/IGPUImage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
namespace nbl::video
1919
{
2020

21-
class NBL_API IGPUImage : public core::impl::ResolveAlignment<IDriverMemoryBacked,asset::IImage>, public IBackendObject
21+
class NBL_API IGPUImage : public core::impl::ResolveAlignment<IDeviceMemoryBacked,asset::IImage>, public IBackendObject
2222
{
2323
private:
2424
using base_t = core::impl::ResolveAlignment<IDeviceMemoryBacked, asset::IImage>;

include/nbl/video/alloc/StreamingTransientDataBuffer.h

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,14 @@
1515
namespace nbl::video
1616
{
1717

18-
<<<<<<< HEAD
19-
template<typename _size_type=uint32_t, class CPUAllocator=core::allocator<uint8_t>, class CustomDeferredFreeFunctor=void, class RecursiveLockable=std::recursive_mutex>
20-
class NBL_API StreamingTransientDataBufferMT;
2118

22-
namespace impl
23-
{
24-
template<typename _size_type=uint32_t, class CPUAllocator=core::allocator<uint8_t>, class CustomDeferredFreeFunctor=void>
25-
class NBL_API StreamingTransientDataBuffer
26-
=======
2719
template<class HostAllocator=core::allocator<uint8_t>, class RecursiveLockable=std::recursive_mutex>
2820
class StreamingTransientDataBufferMT;
2921

3022
namespace impl
3123
{
3224
template<class HostAllocator>
3325
class StreamingTransientDataBuffer
34-
>>>>>>> c4f7993ce2a3e806c5cbaa5dd539ca53d22f0ec5
3526
{
3627
using ThisType = StreamingTransientDataBuffer<HostAllocator>;
3728
using Composed = impl::CAsyncSingleBufferSubAllocator<core::GeneralpurposeAddressAllocator<uint32_t>,HostAllocator>;
@@ -113,13 +104,8 @@ class StreamingTransientDataBuffer
113104
};
114105
}
115106

116-
<<<<<<< HEAD
117-
template<typename _size_type=uint32_t, class CPUAllocator=core::allocator<uint8_t>, class CustomDeferredFreeFunctor=void>
118-
class NBL_API StreamingTransientDataBufferST : public core::IReferenceCounted, public impl::StreamingTransientDataBuffer<_size_type,CPUAllocator,CustomDeferredFreeFunctor>
119-
=======
120107
template<class HostAllocator=core::allocator<uint8_t>>
121108
class StreamingTransientDataBufferST : public core::IReferenceCounted, public impl::StreamingTransientDataBuffer<HostAllocator>
122-
>>>>>>> c4f7993ce2a3e806c5cbaa5dd539ca53d22f0ec5
123109
{
124110
using Base = impl::StreamingTransientDataBuffer<HostAllocator>;
125111

@@ -131,13 +117,8 @@ class StreamingTransientDataBufferST : public core::IReferenceCounted, public im
131117
StreamingTransientDataBufferST(Args&&... args) : Base(std::forward<Args>(args)...) {}
132118
};
133119

134-
<<<<<<< HEAD
135-
template<typename _size_type, class CPUAllocator, class CustomDeferredFreeFunctor, class RecursiveLockable>
136-
class NBL_API StreamingTransientDataBufferMT : public core::IReferenceCounted
137-
=======
138120
template<class HostAllocator, class RecursiveLockable>
139121
class StreamingTransientDataBufferMT : public core::IReferenceCounted
140-
>>>>>>> c4f7993ce2a3e806c5cbaa5dd539ca53d22f0ec5
141122
{
142123
using Composed = impl::StreamingTransientDataBuffer<HostAllocator>;
143124

0 commit comments

Comments
 (0)